Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-wiki templates #376

Merged
merged 46 commits into from
Feb 15, 2021
Merged

Per-wiki templates #376

merged 46 commits into from
Feb 15, 2021

Conversation

supertassu
Copy link
Collaborator

@supertassu supertassu commented Dec 6, 2020

This is built on top of #373. Changes only in this PR.

This will link templates to a certain wiki. It is done in three separate migrations:

  • First, add a nullable wiki_id column to the templates table. It has a foreign key on wikis.id with on delete cascade, meaning that the templates will be removed if the wiki is removed. Add an index on wiki_id, active for efficient queries.
  • Second, backfill wiki_id to always point to enwiki. This step requires that utrs-maintenance:sync-wikis-to-database has been run if there are any templates in the database. (should be done by a migration)
  • Last, remove make wiki_id not nullable as all templates should have a value by now

@supertassu supertassu added the enhancement New feature or request label Dec 6, 2020
@supertassu supertassu added this to the Multi-wiki support milestone Dec 6, 2020
@supertassu supertassu self-assigned this Dec 6, 2020
@supertassu supertassu changed the title Add database schema and list UI for storing wikis in the database Per-wiki templates Dec 6, 2020
@dqwiki dqwiki added the merge & testing issues When there have been changes merged that cause conflicts with the PR at hand label Feb 14, 2021
@dqwiki
Copy link
Member

dqwiki commented Feb 14, 2021

I will also note that there is no way to modify which appeal is assigned to which wiki.

@dqwiki dqwiki merged commit f621950 into master Feb 15, 2021
@dqwiki dqwiki deleted the per-wiki-templates branch February 15, 2021 19:52
@supertassu supertassu mentioned this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request merge & testing issues When there have been changes merged that cause conflicts with the PR at hand
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants