Per-wiki templates

app/Http/Controllers/AdminController.php

@@ -2,6 +2,7 @@
 
 namespace App\Http\Controllers;
 
+use App\Models\Wiki;
 use App\Models\Appeal;
 use App\Models\Ban;
 use App\Models\LogEntry;
@@ -33,33 +34,69 @@ public function listsitenotices()
         return view('admin.tables', ['title' => 'All Sitenotices', 'tableheaders' => $tableheaders, 'rowcontents' => $rowcontents]);
     }
 
-    public function listtemplates()
+    public function listtemplates(Request $request)
     {
-        $this->authorize('viewAny', Template::class);
-        $alltemplates = Template::all();
+        /** @var User $user */
+        $user = $request->user();
+        $wikis = Wiki::get()
+            ->filter(function (Wiki $wiki) use ($user) {
+                return $user->can('viewAny', [Template::class, $wiki]);
+            })
+            ->pluck('id');
+
+        if ($wikis->isEmpty()) {
+            abort(403, "You can't view templates in any wikis!");
+            return '';
+        }
+
+        $templates = Template::with('wiki')
+            ->whereIn('wiki_id', $wikis)
+            ->get();
 
         $tableheaders = ['ID', 'Name', 'Contents', 'Active'];
+        if ($wikis->count() > 1) {
+            $tableheaders[] = 'Wiki';
+        }
+
         $rowcontents = [];
 
-        foreach ($alltemplates as $template) {
-            $idbutton = '<a href="/admin/templates/' . $template->id . '"><button type="button" class="btn btn-primary">' . $template->id . '</button></a>';
+        foreach ($templates as $template) {
+            $idbutton = '<a href="/admin/templates/' . $template->id . '" class="btn btn-primary">' . $template->id . '</a>';
             $active = $template->active ? 'Yes' : 'No';
+
             $rowcontents[$template->id] = [$idbutton, $template->name, htmlspecialchars($template->template), $active];
+
+            if ($wikis->count() > 1) {
+                $wikiName = $template->wiki->display_name . ' (' . $template->wiki->database_name . ')';
+                $rowcontents[$template->id][] = $wikiName;
+            }
         }
 
         return view('admin.tables', ['title' => 'All Templates', 'tableheaders' => $tableheaders, 'rowcontents' => $rowcontents, 'new' => true, 'createlink' => '/admin/templates/create', 'createtext' => 'New template']);
     }
 
-    public function showNewTemplate()
+    public function showNewTemplate(Request $request)
     {
-        $this->authorize('create', Template::class);
-        return view('admin.newtemplate');
+        /** @var User $user */
+        $user = $request->user();
+        $wikis = Wiki::get()
+            ->filter(function (Wiki $wiki) use ($user) {
+                return $user->can('create', [Template::class, $wiki]);
+            })
+            ->mapWithKeys(function (Wiki $wiki) {
+                return [$wiki->id => $wiki->display_name . ' (' . $wiki->database_name . ')'];
+            });
+
+        if ($wikis->isEmpty()) {
+            abort(403, "You can't create templates in any wikis!");
+            return '';
+        }
+
+        return view('admin.newtemplate', ['wikis' => $wikis]);
     }
 
     public function makeTemplate(Request $request)
     {
-        $this->authorize('create', Template::class);
-
         $ua = $request->userAgent();
         $ip = $request->ip();
         $lang = $request->header('Accept-Language');
@@ -68,8 +105,11 @@ public function makeTemplate(Request $request)
             'name' => ['required', 'min:2', 'max:128', Rule::unique('templates', 'name')],
             'template' => 'required|min:2|max:2048',
             'default_status' => ['required', Rule::in(Appeal::REPLY_STATUS_CHANGE_OPTIONS)],
+            'wiki_id' => 'required|exists:wikis,id',
         ]);
 
+        $this->authorize('create', [Template::class, Wiki::findOrFail($data['wiki_id'])]);
+
         $data['active'] = 1;
 
         $template = Template::create($data);
@@ -78,10 +118,22 @@ public function makeTemplate(Request $request)
         return redirect()->to('/admin/templates');
     }
 
-    public function editTemplate(Template $template)
+    public function editTemplate(Request $request, Template $template)
     {
         $this->authorize('update', $template);
-        return view('admin.edittemplate', ["template" => $template]);
+
+        /** @var User $user */
+        $user = $request->user();
+
+        $wikis = Wiki::get()
+            ->filter(function (Wiki $wiki) use ($user) {
+                return $user->can('create', [Template::class, $wiki]);
+            })
+            ->mapWithKeys(function (Wiki $wiki) {
+                return [$wiki->id => $wiki->display_name . ' (' . $wiki->database_name . ')'];
+            });
+
+        return view('admin.edittemplate', ["template" => $template, 'wikis' => $wikis]);
     }
 
     public function updateTemplate(Request $request, Template $template)
@@ -96,10 +148,19 @@ public function updateTemplate(Request $request, Template $template)
             'name' => ['required', 'min:2', 'max:128', Rule::unique('templates', 'name')->ignore($template->id)],
             'template' => 'required|min:2|max:2048',
             'default_status' => ['required', Rule::in(Appeal::REPLY_STATUS_CHANGE_OPTIONS)],
+            'wiki_id' => 'required|exists:wikis,id',
         ]);
 
+        $logText = 'update';
+
+        if ($data['wiki_id'] != $template->wiki_id) {
+            $newWiki = Wiki::findOrFail($data['wiki_id']);
+            $this->authorize('create', [Template::class, $newWiki]);
+            $logText .= ', change wiki to ' . $newWiki->database_name;
+        }
+
         $template->update($data);
-        LogEntry::create(array('user_id' => Auth::id(), 'model_id' => $template->id, 'model_type' => Template::class, 'action' => 'update', 'ip' => $ip, 'ua' => $ua . " " . $lang));
+        LogEntry::create(array('user_id' => Auth::id(), 'model_id' => $template->id, 'model_type' => Template::class, 'action' => $logText, 'ip' => $ip, 'ua' => $ua . " " . $lang));
         return redirect()->to('/admin/templates');
     }
 }

app/Http/Controllers/AppealController.php

@@ -4,6 +4,7 @@
 
 use App\Models\Appeal;
 use App\Models\LogEntry;
+use App\Models\Wiki;
 use App\Models\Old\Oldappeal;
 use App\Models\Old\Olduser;
 use App\Models\Privatedata;
@@ -302,7 +303,12 @@ public function viewtemplates(Request $request, Appeal $appeal)
     {
         $this->authorize('update', $appeal);
 
-        $templates = Template::where('active', '=', 1)->get();
+        $templates = Template::where('active', true)
+            ->whereHas('wiki', function (Builder $query) use ($appeal) {
+                $query->where('database_name', $appeal->wiki);
+            })
+            ->get();
+
         return view('appeals.templates', ['templates' => $templates, 'appeal' => $appeal, 'username' => $request->user()->username]);
     }
 

app/Models/Template.php

@@ -12,4 +12,12 @@ class Template extends Model
     protected $primaryKey = 'id';
     public $timestamps = false;
     protected $guarded = ['id'];
+    protected $casts = [
+        'active' => 'boolean',
+    ];
+
+    public function wiki()
+    {
+        return $this->belongsTo(Wiki::class);
+    }
 }

app/Models/Wiki.php

@@ -13,4 +13,9 @@ class Wiki extends Model
     protected $casts = [
         'is_accepting_appeals' => 'boolean',
     ];
+
+    public function templates()
+    {
+        return $this->hasMany(Template::class);
+    }
 }

app/Policies/Admin/TemplatePolicy.php

@@ -2,6 +2,7 @@
 
 namespace App\Policies\Admin;
 
+use App\Models\Wiki;
 use App\Models\Template;
 use App\Models\User;
 use Illuminate\Auth\Access\HandlesAuthorization;
@@ -14,11 +15,16 @@ class TemplatePolicy
      * Determine whether the user can view any templates.
      *
      * @param User $user
+     * @param Wiki|null $wiki
      * @return mixed
      */
-    public function viewAny(User $user)
+    public function viewAny(User $user, ?Wiki $wiki = null)
     {
-        return $user->hasAnySpecifiedPermsOnAnyWiki(['tooladmin']);
+        if (!$wiki) {
+            return $user->hasAnySpecifiedPermsOnAnyWiki('tooladmin');
+        }
+
+        return $user->hasAnySpecifiedLocalOrGlobalPerms($wiki->database_name, 'tooladmin');
     }
 
     /**
@@ -30,18 +36,19 @@ public function viewAny(User $user)
      */
     public function view(User $user, Template $template)
     {
-        return $user->hasAnySpecifiedPermsOnAnyWiki(['tooladmin']);
+        return $user->hasAnySpecifiedLocalOrGlobalPerms($template->wiki->database_name, 'tooladmin');
     }
 
     /**
      * Determine whether the user can create templates.
      *
      * @param User $user
+     * @param Wiki $wiki
      * @return mixed
      */
-    public function create(User $user)
+    public function create(User $user, Wiki $wiki)
     {
-        return $user->hasAnySpecifiedPermsOnAnyWiki(['tooladmin']);
+        return $user->hasAnySpecifiedLocalOrGlobalPerms($wiki->database_name, 'tooladmin');
     }
 
     /**
@@ -53,7 +60,7 @@ public function create(User $user)
      */
     public function update(User $user, Template $template)
     {
-        return $user->hasAnySpecifiedPermsOnAnyWiki(['tooladmin']);
+        return $user->hasAnySpecifiedLocalOrGlobalPerms($template->wiki->database_name, 'tooladmin');
     }
 
     /**
@@ -65,6 +72,6 @@ public function update(User $user, Template $template)
      */
     public function delete(User $user, Template $template)
     {
-        return $user->hasAnySpecifiedPermsOnAnyWiki(['tooladmin']);
+        return $user->hasAnySpecifiedLocalOrGlobalPerms($template->wiki->database_name, 'tooladmin');
     }
 }

database/factories/TemplateFactory.php

@@ -26,6 +26,7 @@ public function definition()
             'name' => implode(' ', $this->faker->words(3)),
             'template' => implode("\n\n", $this->faker->sentences(2)),
             'active' => $this->faker->boolean(80),
+            'wiki_id' => 1, // this should always exist, as there is a seed to add it
         ];
     }
 

database/migrations/2020_12_06_095703_add_wiki_id_to_templates.php

@@ -0,0 +1,41 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class AddWikiIdToTemplates extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::table('templates', function (Blueprint $table) {
+            $table->unsignedBigInteger('wiki_id')
+                ->nullable(true);
+
+            $table->foreign('wiki_id')
+                ->references('id')
+                ->on('wikis')
+                ->onDelete('cascade');
+            $table->index(['wiki_id', 'active']);
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::table('templates', function (Blueprint $table) {
+            $table->dropForeign(['wiki_id']);
+            $table->dropIndex(['wiki_id', 'active']);
+            $table->dropColumn('wiki_id');
+        });
+    }
+}

database/migrations/2020_12_06_100237_backfill_wiki_id_to_templates.php

@@ -0,0 +1,45 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+
+class BackfillWikiIdToTemplates extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        $count = DB::table('templates')->count();
+        if ($count == 0) {
+            return;
+        }
+
+        $wikiId = DB::table('wikis')
+            ->where('database_name', 'enwiki')
+            ->pluck('id')
+            ->first();
+        if (!$wikiId) {
+            throw new RuntimeException('Please synchronize wikis to the database before running this migration.');
+        }
+
+        DB::table('templates')
+            ->update([
+                'wiki_id' => $wikiId,
+            ]);
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        DB::table('templates')
+            ->update([
+                'wiki_id' => null,
+            ]);
+    }
+}

database/migrations/2020_12_06_100617_make_wiki_id_non_nullable_in_templates.php

@@ -0,0 +1,36 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class MakeWikiIdNonNullableInTemplates extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::table('templates', function (Blueprint $table) {
+            $table->unsignedBigInteger('wiki_id')
+                ->nullable(false)
+                ->change();
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::table('templates', function (Blueprint $table) {
+            $table->unsignedBigInteger('wiki_id')
+                ->nullable(true)
+                ->change();
+        });
+    }
+}