Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CURA-11887] Fuzzy Skin Outside Only: Settings for what's considered 'Outside'. #19324

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[CURA-11887] Fuzzy Skin Outside Only: Settings for what's considered 'Outside'. #19324

wants to merge 4 commits into from

Conversation

rburema
Copy link
Member

@rburema rburema commented Jul 4, 2024 •
edited by wawanbreton
Loading

See the matching backend PR for the full story.

CURA-11887

Fixes #18859 (comment)

rburema and others added 4 commits July 4, 2024 08:52
@rburema
Add settiungs for 'conditional outside' for fuzzy skin.
ed070b3 
Give the user more control over what is considered 'inside' or 'outside' of the model when the 'outside only' option is on for 'magic fuzzy skin'/'outer wall jitter'.

part of CURA-11887
@rburema @github-actions
Applied printer-linter format
45f115e
@rburema
Fuzzy skin outside-only detection: Set defaults to 'old behaviour'.
91b8ac3 
Policy to not confuse already existing users.

part of CURA-11887
@rburema
Fuzzy skin outside-only detection: Set visibility for new settings.
c825071 
part of CURA-11887
This was referenced Jul 4, 2024
Open
Open
wawanbreton
wawanbreton approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names and descriptions are a bit hard to read, but I think that's the best we can have 😅
Also shouldn't we set settable_pre_extruder to True, or is it implied by settable_per_mesh ?

@rburema
Copy link
Member Author

rburema commented Jul 9, 2024

The names and descriptions are a bit hard to read, but I think that's the best we can have 😅

Yeah, there's only two big problems in programming, and they're the halting problem, naming things and off by one errors :-p

Also shouldn't we set settable_pre_extruder to True, or is it implied by settable_per_mesh ?

I'm not sure if that's implied, can't hurt to add it. - I'll make a commit later.

@rburema
Copy link
Member Author

rburema commented Jul 9, 2024

Ah no actually, I remember why I did that; this is the way enabling fuzzy skin also works. So I'm not going to mess with this further (and just focus on the bugs we still have for beta).

@wawanbreton
Copy link
Contributor

Oh yes, makes sense. You don't really want to enable it by extruder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawanbreton wawanbreton wawanbreton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fuzzy Skin never Outside Only
2 participants
@rburema @wawanbreton