[CURA-11887] Fuzzy Skin Outside Only: Make definition of 'inside' user-settable #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand the 'only fuzzy in outside' setting to also mean things the user reasonably could consider inside, instead of just completely closed holes. Take the (approximate) convex hull of the shape, take the difference to get candidate parts that could be considered to be inside of the shape -- then, for each part, determine where it touches the outside. The ratio between how much 'outside' outline and total outline of such a shape (as well as a general size of the hole if ther _is_ any 'outside') determines if points on the polygon thouching that part (outside of the original polygon but inside the approx convex hull) will get 'fuzzed' or not. part of CURA-11887
Also make the ratio always true even when 0 by replacing < with <=, so fully enclosed areas don't get fuzzed/jittered ever if outside only is on. part CURA-11887
This was referenced Jul 4, 2024
[CURA-11887] Fuzzy Skin Outside Only: Settings for what's considered 'Outside'.
Ultimaker/Cura#19324
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for the Fuzzy Skin Outside Only setting, the definition of 'inside' was only areas that are fully enclosed within a layer.
With these changes (see also the necessary added settings in the front-end), it is now possible to define 'sufficiently convex' areas as 'inside' as well -- skipping these areas when jittering the outer-wall.
The new settings are: