CURA-11501 Fix excluded materials being sometimes visible #19539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wawanbreton
commented
Aug 15, 2024
It's not enough (or even nescesary) to mock the (now wrapper) method, since we use the underlaying method in our code now. done as part of CURA-11501
done as part of CURA-11501
HellAholic
approved these changes
Aug 16, 2024
HellAholic
deleted the
CURA-11501_switching_printers_loads_3rd_party_materials
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the
exclude_materialsproperty ofMachineNodehas changed over time, and one of its use has not been updated, leading to some cases where materials could be non excluded.