Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CURA-11501 Fix excluded materials being sometimes visible #19539

Merged
merged 6 commits into from
Aug 16, 2024
Merged

CURA-11501 Fix excluded materials being sometimes visible #19539

merged 6 commits into from
Aug 16, 2024

Commits on Aug 15, 2024

  1. Use proper method to check for excluded materials 

    CURA-11501
    @wawanbreton
    wawanbreton committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    1e5fa85 View commit details
    Browse the repository at this point in the history

  2. Fix unit test

    @wawanbreton
    wawanbreton committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b8bba65 View commit details
    Browse the repository at this point in the history

  3. Split methods to prevent API-break. 

    done as part of CURA-11501
    @rburema
    rburema committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8805c6a View commit details
    Browse the repository at this point in the history

  4. Fix unit test. 

    It's not enough (or even nescesary) to mock the (now wrapper) method, since we use the underlaying method in our code now.

done as part of CURA-11501
    @rburema
    rburema committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    922c8cc View commit details
    Browse the repository at this point in the history

  5. Mark isExcludedMaterial as deprecated. 

    done as part of CURA-11501
    @rburema
    rburema committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    268fd35 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Fix unit test 

    CURA-11501
    @wawanbreton
    wawanbreton committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    785287e View commit details
    Browse the repository at this point in the history