Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NP- 327 emscripten communication #2131

Merged
merged 36 commits into from
Aug 30, 2024
Merged

Commits on Aug 1, 2024

  1. Use smart pointer for communication

    Contribute to NP-327
    jellespijker committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    5ea8d8f View commit details
    Browse the repository at this point in the history
  2. Introduce EmscriptenCommunication class

    Contribute to NP-327
    jellespijker committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1d066a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Enable Emscripten support in communication module

    Refactored conditional compilation to enable Emscripten-specific behavior in the communication module. Updated CMakeLists.txt to handle Emscripten build settings and refactored EmscriptenCommunication to properly manage progress handling and command-line arguments.
    
    Contribute to NP-327
    jellespijker committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0533f8c View commit details
    Browse the repository at this point in the history
  2. Applied clang-format.

    jellespijker authored and github-actions[bot] committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    cf6ef1f View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Enable slice info callback for Emscripten communication

    This commit adds support for handling slice info callbacks through Emscripten, alongside progress callbacks. Additionally, functions to create slice info messages using rapidjson were implemented to prepare JSON data for slice information.
    
    Contribute to NP-327
    jellespijker committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    f291338 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Switch to smart pointers

    Replaced raw pointers with `std::shared_ptr` for better memory management. Standardized variable names to follow consistent naming conventions, improving code readability and maintainability.
    
    This was needed because the reference to Slice was otherwise out-of-scope when calling `Emscripten::sliceNext()`
    
    Contribute to NP-327
    jellespijker committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e3a14ab View commit details
    Browse the repository at this point in the history
  2. Applied clang-format.

    jellespijker authored and github-actions[bot] committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    c788fae View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Switch to shared_ptr for better memory management

    Replaced unique_ptr with shared_ptr in various components to facilitate shared ownership of resources and prevent manual memory management. This change affects communication objects, `Slice` instances, and related test cases to ensure smooth integration.
    
    Contribute to NP-327
    jellespijker committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    b96cf27 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/NP-327_emscripten_communication'…

    … into NP-327_emscripten_communication
    jellespijker committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    40c342c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    35ffb22 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Document EmscriptenCommunication class.

    Added detailed documentation comments for the EmscriptenCommunication class, including descriptions for member variables and methods. This improves code readability and ease of maintenance.
    
    Contribute to NP-327
    jellespijker committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    eb3eda6 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/NP-327_emscripten_communication'…

    … into NP-327_emscripten_communication
    jellespijker committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e3d815c View commit details
    Browse the repository at this point in the history
  3. Apply review suggestions

    Contribute to NP-327
    jellespijker committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9b4a913 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Configuration menu
    Copy the full SHA
    6697713 View commit details
    Browse the repository at this point in the history
  2. refactor(FffGcodeWriter): fix extruder order calculation bug

    The return type of getTotalExtraLayer function on Raft is casted to the value_type to prevent underflow. This previously resulted in method xl to generate invalid gcode.
    0x5844 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0f8e04f View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    18cf586 View commit details
    Browse the repository at this point in the history
  2. Applied clang-format.

    saumyaj3 authored and github-actions[bot] committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ee99fda View commit details
    Browse the repository at this point in the history
  3. fixing typo in .h file

    NP-351
    saumyaj3 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    77db867 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2a6b939 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    463df70 View commit details
    Browse the repository at this point in the history
  6. Apply review suggestions

    Contribute to NP-327
    jellespijker committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b45dd95 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Fix UT

    Contribute to NP-327
    jellespijker committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    714f3e8 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/NP-343-slicing-for-a-method-xl-p…

    …roduces-unexpected-results' into NP-327_emscripten_communication
    jellespijker committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    cabaa89 View commit details
    Browse the repository at this point in the history
  3. Communication isn't sequential

    Contribute to NP-327
    jellespijker committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    63a84d0 View commit details
    Browse the repository at this point in the history
  4. Applied clang-format.

    jellespijker authored and github-actions[bot] committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f87791a View commit details
    Browse the repository at this point in the history
  5. Refactor GCode handler variable and command line flag names

    Renamed `gcode_prefix_handler_` to `gcode_header_handler_` for clarity. Updated corresponding usage in `EmscriptenCommunication.h`, `CommandLine.cpp`, and `EmscriptenCommunication.cpp`.
    
    Contribute to NP-327
    jellespijker committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d5afe4f View commit details
    Browse the repository at this point in the history
  6. Fix GCode prefix formatting in EmscriptenCommunication

    Ensure the prefix argument is correctly formatted as a string in JavaScript function calls. This change prevents potential issues with GCode prefix handling in the communication module as it starts with ';'
    
    NP-327
    saumyaj3 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    38c59c3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e5b17f9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b9d5ef6 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'NP-327_emscripten_communication' of github.com:Ultimake…

    …r/CuraEngine into NP-327_emscripten_communication
    0x5844 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    030ee68 View commit details
    Browse the repository at this point in the history
  10. Add base64 encoding for GCode prefix handling.

    Implemented a `convertTobase64` function to encode strings to base64, ensuring they can be safely transmitted in JavaScript. Updated `EmscriptenCommunication::sendGCodePrefix` to use this new encoding method and modified relevant tests accordingly to check this functionality.
    
    NP-327
    saumyaj3 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5c564a3 View commit details
    Browse the repository at this point in the history
  11. Applied clang-format.

    saumyaj3 authored and github-actions[bot] committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1177f6f View commit details
    Browse the repository at this point in the history
  12. Rename handler for GCode prefix transmission.

    NP-327
    saumyaj3 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    bf76f58 View commit details
    Browse the repository at this point in the history
  13. Update include/communication/EmscriptenCommunication.h

    Co-authored-by: Erwan MATHIEU <[email protected]>
    jellespijker and wawanbreton authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a45a607 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Refactor to use existing mesh group object

    assuming that cloud slicer does not create multiple mesh groups, but one.
    
    NP-351
    saumyaj3 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    98cb105 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Configuration menu
    Copy the full SHA
    b719a42 View commit details
    Browse the repository at this point in the history