Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a debugRoutingConfig param and a UnicornSecret #290

Merged
merged 6 commits into from
Aug 20, 2023
Merged

Create a debugRoutingConfig param and a UnicornSecret #290

merged 6 commits into from
Aug 20, 2023

Conversation

mikeki
Copy link
Contributor

@mikeki mikeki commented Aug 18, 2023 •
edited by jsy1218
Loading

@jsy1218 jsy1218 self-requested a review August 20, 2023 19:14
jsy1218
jsy1218 approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@jsy1218 jsy1218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also added the secret into Pipeline account

@jsy1218 jsy1218 merged commit 22b2146 into main Aug 20, 2023
3 checks passed
@jsy1218 jsy1218 deleted the mikeki/debug_configs branch August 20, 2023 20:27
jsy1218 added a commit that referenced this pull request Aug 20, 2023
@jsy1218
Revert "Create a debugRoutingConfig param and a UnicornSecret (#290)"
047c4b8 
This reverts commit 22b2146.
jsy1218 added a commit that referenced this pull request Aug 20, 2023
@jsy1218
Revert "Create a debugRoutingConfig param and a UnicornSecret (#290)"…
b7f0630 
… - see more details in descriptions (#301)

Revert "Create a debugRoutingConfig param and a UnicornSecret (#290)"

This reverts commit 22b2146.
jsy1218 added a commit that referenced this pull request Aug 20, 2023
@jsy1218
Revert "Revert "Create a debugRoutingConfig param and a UnicornSecret (…
5c1a006 
…#290)" - see more details in descriptions (#301)"

This reverts commit b7f0630.
jsy1218 added a commit that referenced this pull request Aug 20, 2023
@jsy1218
Revert "Revert "Create a debugRoutingConfig param and a UnicornSecret (…
8443baa 
…#290)" - see more details in descriptions (#301)" (#302)

This reverts commit b7f0630.
jsy1218 added a commit that referenced this pull request Aug 21, 2023
@jsy1218
Revert "Create a debugRoutingConfig param and a UnicornSecret (#290)"
581a0f0 
This reverts commit 22b2146.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsy1218 jsy1218 jsy1218 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeki @jsy1218