Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Create a debugRoutingConfig param and a UnicornSecret (#290)" - see more details in descriptions #301

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Aug 20, 2023

We revert, because the codepipeline beta-us-east-2 retry does not retrigger RoutingAPI.Prepare, which does not build CloudFormation resource anymore.

Screenshot 2023-08-20 at 2 44 27 PM

We did find the reason Codepipeline failed was due to:

User: arn:aws:sts::145079444317:assumed-role/cdk-hnb659fds-cfn-exec-role-145079444317-us-east-2/AWSCloudFormation is not authorized to perform: secretsmanager:GetSecretValue on resource: arn:aws:secretsmanager:us-east-2:644039819003:secret:debug-config-unicornsecrets-jvmCsq because no resource-based policy allows the secretsmanager:GetSecretValue action (Service: AWSSecretsManager; Status Code: 400; Error Code: AccessDeniedException; Request ID: 0b587919-9f34-46c7-a0da-0809f2dfc06c; Proxy: null)

But we added the policy to secrets afterwards (it seems like we always manually add policy to secrets instead of programmatically, since it's from cloudformation to secrets, not between stack to resource).

We don't believe there's any wrong with the change, so we will revert revert again.

@jsy1218 jsy1218 requested a review from mikeki August 20, 2023 21:53
@jsy1218 jsy1218 self-assigned this Aug 20, 2023
@jsy1218 jsy1218 changed the title Revert "Create a debugRoutingConfig param and a UnicornSecret (#290)" Revert "Create a debugRoutingConfig param and a UnicornSecret (#290)" - see more details in descriptions Aug 20, 2023
@jsy1218 jsy1218 merged commit b7f0630 into main Aug 20, 2023
3 checks passed
@jsy1218 jsy1218 deleted the jsy1218/revert_debug_configs branch August 20, 2023 22:14
jsy1218 added a commit that referenced this pull request Aug 20, 2023
…#290)" - see more details in descriptions (#301)"

This reverts commit b7f0630.
jsy1218 added a commit that referenced this pull request Aug 20, 2023
…#290)" - see more details in descriptions (#301)" (#302)

This reverts commit b7f0630.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants