Revert "Create a debugRoutingConfig param and a UnicornSecret (#290)" - see more details in descriptions #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We revert, because the codepipeline beta-us-east-2 retry does not retrigger
RoutingAPI.Prepare
, which does not buildCloudFormation
resource anymore.We did find the reason Codepipeline failed was due to:
But we added the policy to secrets afterwards (it seems like we always manually add policy to secrets instead of programmatically, since it's from cloudformation to secrets, not between stack to resource).
We don't believe there's any wrong with the change, so we will revert revert again.