forked from mono/mono
-
Notifications
You must be signed in to change notification settings - Fork 513
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[System]: Use new
WebCompletionSource instead of `TaskCompletionSou…
…rce`. (mono#7293) This new helper class uses `TaskCompletionSource<>` internally, but instead of using TrySetException(), it sets a result containing an `ExceptionDispatchInfo`. The problem with using TrySetException() is that it wraps the exception object in an `AggregateException`, that would be unobserved if the caller throws the original exception.
- Loading branch information
Showing
5 changed files
with
145 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| // | ||
| // WebCompletionSource.cs | ||
| // | ||
| // Author: | ||
| // Martin Baulig <[email protected]> | ||
| // | ||
| // Copyright (c) 2018 Xamarin Inc. (http://www.xamarin.com) | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
| using System; | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
| using System.Runtime.ExceptionServices; | ||
|
|
||
| namespace System.Net | ||
| { | ||
| class WebCompletionSource | ||
| { | ||
| TaskCompletionSource<Result> completion; | ||
|
|
||
| public WebCompletionSource () | ||
| { | ||
| completion = new TaskCompletionSource<Result> (); | ||
| } | ||
|
|
||
| public bool TrySetCompleted () | ||
| { | ||
| return completion.TrySetResult (new Result (State.Completed, null)); | ||
| } | ||
|
|
||
| public bool TrySetCanceled () | ||
| { | ||
| var error = new OperationCanceledException (); | ||
| var result = new Result (State.Canceled, ExceptionDispatchInfo.Capture (error)); | ||
| return completion.TrySetResult (result); | ||
| } | ||
|
|
||
| public bool TrySetException (Exception error) | ||
| { | ||
| var result = new Result (State.Faulted, ExceptionDispatchInfo.Capture (error)); | ||
| return completion.TrySetResult (result); | ||
| } | ||
|
|
||
| public bool IsCompleted => completion.Task.IsCompleted; | ||
|
|
||
| public void ThrowOnError () | ||
| { | ||
| if (!completion.Task.IsCompleted) | ||
| return; | ||
| completion.Task.Result.Error?.Throw (); | ||
| } | ||
|
|
||
| public async Task<bool> WaitForCompletion (bool throwOnError) | ||
| { | ||
| var result = await completion.Task.ConfigureAwait (false); | ||
| if (result.State == State.Completed) | ||
| return true; | ||
| if (throwOnError) | ||
| result.Error.Throw (); | ||
| return false; | ||
| } | ||
|
|
||
| enum State : int { | ||
| Running, | ||
| Completed, | ||
| Canceled, | ||
| Faulted | ||
| } | ||
|
|
||
| class Result | ||
| { | ||
| public State State { | ||
| get; | ||
| } | ||
|
|
||
| public ExceptionDispatchInfo Error { | ||
| get; | ||
| } | ||
|
|
||
| public Result (State state, ExceptionDispatchInfo error) | ||
| { | ||
| State = state; | ||
| Error = error; | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters