[System]: Use new WebCompletionSource instead of TaskCompletionSource.
#7293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@monojenkins build pkg |
|
@monojenkins backport 2018-02 |
baulig
force-pushed
the
work-unobserved-exceptions
branch
from
32a6eaf
to
4075747
Compare
|
@monojenkins build pkg |
…rce<>`. This new helper class uses `TaskCompletionSource<>` internally, but instead of using TrySetException(), it sets a result containing an `ExceptionDispatchInfo`. The problem with using TrySetException() is that it wraps the exception object in an `AggregateException`, that would be unobserved if the caller throws the original exception.
baulig
force-pushed
the
work-unobserved-exceptions
branch
from
4075747
to
1e546e5
Compare
baulig
changed the title
WebCompletionSource instead of TaskCompletionSource<>.WebCompletionSource instead of TaskCompletionSource.
|
@monojenkins build pkg |
|
@monojenkins backport 2018-02 |
marek-safar
requested changes
Feb 27, 2018
| completion = new TaskCompletionSource<Result> (); | ||
| } | ||
|
|
||
| public bool SetCompleted () |
There was a problem hiding this comment.
Should be called TrySetCompleted
| return completion.TrySetResult (new Result (1, null)); | ||
| } | ||
|
|
||
| public bool SetCanceled () |
There was a problem hiding this comment.
Should be called TrySetCanceled
|
|
||
| public bool IsCompleted => completion.Task.IsCompleted; | ||
|
|
||
| public void Throw () |
There was a problem hiding this comment.
This is actually ThrowOnError, right?
|
|
||
| class Result | ||
| { | ||
| public int State { |
marek-safar
approved these changes
Feb 28, 2018
|
@monojenkins backport 2018-02 |
UnityAlex
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Aug 29, 2019
…rce`. (mono#7293) This new helper class uses `TaskCompletionSource<>` internally, but instead of using TrySetException(), it sets a result containing an `ExceptionDispatchInfo`. The problem with using TrySetException() is that it wraps the exception object in an `AggregateException`, that would be unobserved if the caller throws the original exception.
UnityAlex
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Sep 3, 2019
…rce`. (mono#7293) This new helper class uses `TaskCompletionSource<>` internally, but instead of using TrySetException(), it sets a result containing an `ExceptionDispatchInfo`. The problem with using TrySetException() is that it wraps the exception object in an `AggregateException`, that would be unobserved if the caller throws the original exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new helper class uses
TaskCompletionSource<>internally, but insteadof using TrySetException(), it sets a result containing an
ExceptionDispatchInfo.The problem with using TrySetException() is that it wraps the exception
object in an
AggregateException, that would be unobserved if the callerthrows the original exception.
#7194