Fix webrequest aggregated exceptions #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 29, 2019 16:11
…rce`. (mono#7293) This new helper class uses `TaskCompletionSource<>` internally, but instead of using TrySetException(), it sets a result containing an `ExceptionDispatchInfo`. The problem with using TrySetException() is that it wraps the exception object in an `AggregateException`, that would be unobserved if the caller throws the original exception.
…ono#10488. (mono#10595) * [System]: Make sure `HttpWebRequest` observes exceptions on timeout. mono#10488. `HttpWebRequest.RunWithTimeoutWorker()` needs to observe the worker task's exception on timeout to prevent it from being thrown via the `TaskScheduler.UnobservedTaskException` event. Fixes mono#10488. * Add `TaskContinuationOptions.OnlyOnFaulted | TaskContinuationOptions.OnlyOnCanceled` as suggested by Marek. * Use 'OnlyFaulted' only.
Fix a regression introduced in the new web stack - when connecting to a DNS host name that resolves to multiple IP addresses, we need to probe them all. On iOS, "localhost" will resolve to both "::1" and "127.0.0.1".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix: https://issuetracker.unity3d.com/issues/cannot-access-a-disposed-object-exception-when-processing-requests-simultaneously-with-a-specified-timeout
The connection was being disposed of on one thread before another thread was still using the connection was done with it. Cherry picking some of the networking refactoring changesets appears to fix the problem.