Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden dependency on underscore.js #246

Open
domq opened this issue Nov 7, 2019 · 0 comments · May be fixed by #247
Open

Hidden dependency on underscore.js #246

domq opened this issue Nov 7, 2019 · 0 comments · May be fixed by #247

Comments

@domq
Copy link

domq commented Nov 7, 2019

Running the master branch of meteor-rxjs in a Meteor 1.9.3 project (that doesn't explicitly use the underscore package) results in the following server-side stack trace:

W20191107-17:14:36.031(1)? (STDERR) ReferenceError: _ is not defined
W20191107-17:14:36.031(1)? (STDERR)     at new ObservableCursor (.../node_modules/meteor-rxjs/dist/bundles/index.umd.js:98:13)
W20191107-17:14:36.032(1)? (STDERR)     at Function.ObservableCursor.create (.../node_modules/meteor-rxjs/dist/bundles/index.umd.js:113:20)
W20191107-17:14:36.032(1)? (STDERR)     at Collection.find (.../node_modules/meteor-rxjs/dist/bundles/index.umd.js:426:41)
[...]

Adding underscore to .meteor/packages makes the problem go away.

It is worth noting that Meteor doesn't use underscore anymore these days.
domq pushed a commit to epfl-fsd/meteor-rxjs that referenced this issue Nov 7, 2019
Stop relying on underscore.js' _ being magically available
bffa937 
Fixes Urigo#246
domq pushed a commit to epfl-fsd/meteor-rxjs that referenced this issue Nov 7, 2019
Stop relying on underscore.js' _ being magically available
acc7d5c 
Fixes Urigo#246

- Use lodash, which is already an indirect dependency
domq pushed a commit to epfl-fsd/meteor-rxjs that referenced this issue Nov 7, 2019
Stop relying on underscore.js' _ being magically available
5bd096b 
Fixes Urigo#246

- Use lodash, which is already an indirect dependency
@domq domq linked a pull request Nov 7, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop relying on underscore.js' _ being magically available epfl-fsd/meteor-rxjs
1 participant
@domq