Skip to content

Commit

Permalink
Stop relying on underscore.js' _ being magically available
Browse files Browse the repository at this point in the history
Fixes Urigo#246

- Use lodash, which is already an indirect dependency
  • Loading branch information
Dominique Quatravaux committed Nov 7, 2019
1 parent 881aa74 commit 5bd096b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,15 @@
},
"homepage": "http://www.angular-meteor.com",
"peerDependencies": {
"lodash": "^4.17.15",
"@types/meteor": "^1.4.6",
"rxjs": "^5.4.3 || ^6.0.0"
},
"devDependencies": {
"@types/chai": "4.0.4",
"@types/meteor": "1.4.14",
"@types/mocha": "2.2.43",
"@types/underscore": "1.8.3",
"@types/lodash": "4.14.142",
"conventional-changelog": "1.1.0",
"conventional-changelog-cli": "1.2.0",
"jsdoc-to-markdown": "3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion src/ObservableCursor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Observable , Subscriber , Subject } from 'rxjs';

import { gZone, forkZone, removeObserver } from './utils';

declare let _;
import * as _ from 'lodash';

export class ObservableCursor<T> extends Observable<T[]> {
private _zone: Zone;
Expand Down
2 changes: 1 addition & 1 deletion src/utils.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Subscriber } from 'rxjs';

declare let _;
import * as _ from 'lodash';

export declare type CallbacksObject = {
onReady?: Function;
Expand Down

0 comments on commit 5bd096b

Please sign in to comment.