Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system metrics #313

Merged
merged 28 commits into from
Apr 24, 2023
Merged

Add system metrics #313

merged 28 commits into from
Apr 24, 2023

Conversation

nevgeny
Copy link
Contributor

@nevgeny nevgeny commented Mar 9, 2023 •
edited
Loading

Close #109

e.martyn added 19 commits February 13, 2023 16:24
[wip] add cpu metrics
3f5ea51
[sqlite] add metrics
98e7fd2
Fix after rebase
b9fdbef
[sqlite] small fixes
2ee90c8
add groups
08a8629
[metadata] migration from blob to text
e2d33fe
add groups
69226d1
small fixes
8b776f2
add prefix check
bce8217
Fix after rebase
3b6073a
fix: user request error
a243825
Merge branch 'master' into temp
f581a6e 
# Conflicts:
#	internal/api/handler.go
[wip] add collector
1f9346a
[wip] add collector
8d23676
add psi metrics
7d75fae
[wip] add builtin modified metrics
0f39b2d
Merge branch 'temp' into emartyn/add-system-metrics
a4e184e 
# Conflicts:
#	internal/api/handler.go
#	internal/api/prometheus.go
#	internal/api/promql_queryable.go
#	internal/metajournal/meta_metrics_test.go
fix system metrics builtin
2f2a2f9
Merge branch 'master' into temp
a8b907c 
# Conflicts:
#	internal/api/handler.go
#	internal/metadata/dbv2.go
#	internal/metajournal/meta_metrics.go
@nevgeny nevgeny requested review from hrissan, flyingmutant and a team as code owners March 9, 2023 14:08
@nevgeny nevgeny force-pushed the emartyn/add-system-metrics branch 7 times, most recently from ac5009c to 18cd82d Compare March 9, 2023 16:27
@nevgeny nevgeny changed the title [WIP] add system metrics Add system metrics Mar 10, 2023
nevgeny
nevgeny commented Mar 10, 2023
View reviewed changes
internal/stats/cpu_stats.go Outdated Show resolved Hide resolved
@nevgeny nevgeny force-pushed the emartyn/add-system-metrics branch 2 times, most recently from f87791c to 4cf37cc Compare March 13, 2023 10:57
flyingmutant
flyingmutant reviewed Apr 4, 2023
View reviewed changes
cmd/collector_test/collector.go Outdated Show resolved Hide resolved
cmd/statshouse/statshouse.go Show resolved Hide resolved
internal/format/format.go Outdated Show resolved Hide resolved
internal/stats/collector.go Outdated Show resolved Hide resolved
internal/stats/cpu_stats.go Outdated Show resolved Hide resolved
internal/stats/cpu_stats.go Outdated Show resolved Hide resolved
internal/format/predefined.go Outdated Show resolved Hide resolved
@flyingmutant
Copy link
Contributor

  • выравниваем сбор по серединам секунд
  • убеждаемся что никакие ненужные привилегии для встроенных метрик мы не получаем (семплирование, например, на агрегаторах точно должно работать; запись должна размазываться по всем шардам и т.п.)
  • делаем метрики по 60с чтобы не выедать много бюджета; когда будут готовы бюджеты групп -- вернемся к сбору по 1с
  • отдельно делаем поддержку встроенных дашбордов и дашборд для системных метрик

@nevgeny nevgeny force-pushed the emartyn/add-system-metrics branch 3 times, most recently from 6286ec8 to 60f57b9 Compare April 24, 2023 10:50
@nevgeny nevgeny merged commit f5e9393 into master Apr 24, 2023
@nevgeny nevgeny deleted the emartyn/add-system-metrics branch April 24, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyingmutant flyingmutant flyingmutant approved these changes

@hrissan hrissan Awaiting requested review from hrissan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue: built-in hardware/system metrics
2 participants
@nevgeny @flyingmutant