Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: エンジンマニフェストにモデルモジュールを追加 #1344

Closed
wants to merge 3 commits into from

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 28, 2024

内容

エンジンマニフェストに関するモデルをエンジンマニフェストモジュール下へ移動するリファクタリングを提案します。

追記:
#1359 で方向性が変わる場合、本 PR は大幅変更となる。一旦 review 不可。

関連 Issue

ref #1278 (comment)

@tarepan tarepan requested a review from a team as a code owner May 28, 2024 14:06
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 28, 2024 14:06
@tarepan tarepan marked this pull request as draft May 29, 2024 19:34
@tarepan
Copy link
Contributor Author

tarepan commented Jun 3, 2024

#1359 受け入れの方向性であるため、本 PR は close とする。

@tarepan tarepan closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant