Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: モジュール docstring を追加 #1278

Merged
merged 14 commits into from
Jun 2, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 19, 2024

内容

PEP257 に基づいてモジュール docstring を追加するリファクタリングを提案します。

関連 Issue

無し

@tarepan tarepan requested a review from a team as a code owner May 19, 2024 05:31
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 19, 2024 05:31
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

結構認識違いがあったのでコメントしました!

voicevox_engine/app/application.py Outdated Show resolved Hide resolved
voicevox_engine/core/core_adapter.py Outdated Show resolved Hide resolved
voicevox_engine/core/core_initializer.py Outdated Show resolved Hide resolved
voicevox_engine/engine_manifest.py Outdated Show resolved Hide resolved
voicevox_engine/model.py Outdated Show resolved Hide resolved
voicevox_engine/setting/Setting.py Outdated Show resolved Hide resolved
voicevox_engine/tts_pipeline/tts_engine.py Outdated Show resolved Hide resolved
voicevox_engine/user_dict/part_of_speech_data.py Outdated Show resolved Hide resolved
voicevox_engine/utility/path_utility.py Show resolved Hide resolved
@tarepan
Copy link
Contributor Author

tarepan commented May 28, 2024

@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re-review よろしくお願いします。

@tarepan
Copy link
Contributor Author

tarepan commented Jun 2, 2024

@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re2-review よろしくお願いします。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit 4b4e6b6 into VOICEVOX:master Jun 2, 2024
4 checks passed
@tarepan tarepan deleted the refactor/module_docstring branch June 3, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants