-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update package, apply new readme style #3
base: main
Are you sure you want to change the base?
Conversation
ptrcksc
commented
Aug 21, 2024
•
edited
Loading
edited
- add phpstan
- add php-cs-fixer
- run code-styling
- format readme
- update composer dependencies, add minimum php 8.1 check
## Installation | ||
## Quick start | ||
|
||
### Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be good to also indicate in the readme what the minimum requirements are? For example because the PHP version has now gone to 8.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PHP version is set in the composer.json file. I personally think this is clean enough, as a user I would expect this to follow Nova's minimum requirements, and PHP's supported versions.
Right now Nova is laravel8/PHP7.3, minimum supported PHP version is 8.1, so PHP 8.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You often see the versions in readme's. Even though a version is configured in composer.json
and the package relies on Nova, it wouldn't hurt to put it in the readme, so anyone that wants to use the package can immediately see what the minimum requirements are.
@ptrcksc One more thing I forgot: |