Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update package, apply new readme style #3
base: main
Are you sure you want to change the base?
chore: Update package, apply new readme style #3
Changes from 2 commits
e7ce6aa
4f4944e
247e7b3
abb3a4a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be good to also indicate in the readme what the minimum requirements are? For example because the PHP version has now gone to
8.1
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PHP version is set in the composer.json file. I personally think this is clean enough, as a user I would expect this to follow Nova's minimum requirements, and PHP's supported versions.
Right now Nova is laravel8/PHP7.3, minimum supported PHP version is 8.1, so PHP 8.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You often see the versions in readme's. Even though a version is configured in
composer.json
and the package relies on Nova, it wouldn't hurt to put it in the readme, so anyone that wants to use the package can immediately see what the minimum requirements are.