Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bgresponse to js_enabled #806

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Change bgresponse to js_enabled #806

merged 2 commits into from
Apr 29, 2022

Conversation

jmctune
Copy link
Contributor

@jmctune jmctune commented Apr 25, 2022

When attempting to authenticate to AWS using GoogleApps SAML, some users are receiving the following error when running the command saml2aws login:

Error authenticating to IdP.: error loading first page: failed to build login form data: could not find any forms matching the provided IDs.

Error page seen when reviewing the response from Google:

image

Previous workaround was to change the provider from GoogleApps to Browser, but this fix should make this no longer necessary.

Changing the bgresponse from js_disabled to js_enabled has fixed this for myself and a user in my organization.

Looking at resources documented in this repo, I came across the same issue in the aws-google-auth project and the proposed PR to fix. This fix has also worked with this project.

I'm unsure what else these parameters drive, but it hasn't stopped existing users from authenticating either.

Open issues:

@mjhoffman65
Copy link

This fix worked for me too. Thank you!

@brianslingshot
Copy link

This fix is working for me as well. Much appreciated!

@js-beaulieu
Copy link

js-beaulieu commented Apr 26, 2022

Can confirm the fix works for me and other colleagues on both Linux and macOS. Thank you.

@apatnaik14
Copy link

I was hoping to confirm can we change the bgresponse value currently on saml2aws version 2.34.0. I am running into the above issue on a VM where I cannot enable the Browser provider.

@jmctune
Copy link
Contributor Author

jmctune commented Apr 26, 2022

I was hoping to confirm can we change the bgresponse value currently on saml2aws version 2.34.0. I am running into the above issue on a VM where I cannot enable the Browser provider.

I tested this change against what's in master and there were no issues, so I imagine you'll be fine with 2.34.0.

@apatnaik14
Copy link

apatnaik14 commented Apr 26, 2022

I was hoping to confirm can we change the bgresponse value currently on saml2aws version 2.34.0. I am running into the above issue on a VM where I cannot enable the Browser provider.

I tested this change against what's in master and there were no issues, so I imagine you'll be fine with 2.34.0.

Thank you for confirming that @jmctune! I was trying to set the bgresponse field on the .saml2aws configuration, but I was unable to get it to work. My verbose logs always showed the setting to be js_disabled. Is that the correct spot for it? I apologize if the steps have already been elaborated in a ticket. If so, I would really appreciate it if you could attach the ticket number which I could refer to to fix this issue in master.

@jt-shippit
Copy link

Hi, I can also confirm this worked for me in both Linux and Apple M1

Copy link

@stephanschielke stephanschielke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me:

cd $GOPATH
git clone [email protected]:Versent/saml2aws.git
cd saml2aws/pkg/provider/googleapps/
wget https://raw.githubusercontent.com/Versent/saml2aws/b044230ac8a2ba5544ecf6927a4947a364910cef/pkg/provider/googleapps/googleapps.go
cd $GOPATH/saml2aws
make mod
make install

@apatnaik14
Copy link

Works for me:

cd $GOPATH
git clone [email protected]:Versent/saml2aws.git
cd saml2aws/pkg/provider/googleapps/
wget https://raw.githubusercontent.com/Versent/saml2aws/b044230ac8a2ba5544ecf6927a4947a364910cef/pkg/provider/googleapps/googleapps.go
cd $GOPATH/saml2aws
make mod
make install

Thanks @stephanschielke @jmctune ! Figured out what I was doing wrong in my VM. The above solution is working for me as well.

@martin-shippit
Copy link

martin-shippit commented Apr 28, 2022

I started getting the dreaded could not find any forms matching the provided IDs. This PR fixed it 👍
This is on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants