-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change bgresponse
to js_enabled
#806
Conversation
This fix worked for me too. Thank you! |
This fix is working for me as well. Much appreciated! |
Can confirm the fix works for me and other colleagues on both Linux and macOS. Thank you. |
I was hoping to confirm can we change the bgresponse value currently on saml2aws version 2.34.0. I am running into the above issue on a VM where I cannot enable the Browser provider. |
I tested this change against what's in |
Thank you for confirming that @jmctune! I was trying to set the |
Hi, I can also confirm this worked for me in both Linux and Apple M1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me:
cd $GOPATH
git clone [email protected]:Versent/saml2aws.git
cd saml2aws/pkg/provider/googleapps/
wget https://raw.githubusercontent.com/Versent/saml2aws/b044230ac8a2ba5544ecf6927a4947a364910cef/pkg/provider/googleapps/googleapps.go
cd $GOPATH/saml2aws
make mod
make install
Thanks @stephanschielke @jmctune ! Figured out what I was doing wrong in my VM. The above solution is working for me as well. |
I started getting the dreaded |
When attempting to authenticate to AWS using GoogleApps SAML, some users are receiving the following error when running the command
saml2aws login
:Error page seen when reviewing the response from Google:
Previous workaround was to change the provider from
GoogleApps
toBrowser
, but this fix should make this no longer necessary.Changing the
bgresponse
fromjs_disabled
tojs_enabled
has fixed this for myself and a user in my organization.Looking at resources documented in this repo, I came across the same issue in the aws-google-auth project and the proposed PR to fix. This fix has also worked with this project.
I'm unsure what else these parameters drive, but it hasn't stopped existing users from authenticating either.
Open issues: