Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bg_response in request payload to passwd challenge #250

Conversation

ezeqme
Copy link

@ezeqme ezeqme commented Apr 19, 2022

This fix resolves the issue reported on #248

When adding the --bg-response parameter, the value is not passed on in the captcha validation request, which causes a validation error.

The error occurs because google blocks the request in new installations due to the default value that informs that there is no support for javascript "bg_response" with value "js_disabled".

It is necessary to pass the value as "bg_response" with value "js_enabled" to avoid the error in the google authentication flow.

But the error continues to occur in the captcha validation because this parameter was not passed on in the challenge response payload.

By adding "bg_response" with value "js_enabled" in the challenge submission, the authentication flow proceeds normally.

This error occurs in new installations of aws-google-auth, not being reproduced in installations that already existed, I can't explain why.

@ezeqme ezeqme changed the title Fix bg_response in request payload to passwd challenge Add bg_response in request payload to passwd challenge Apr 19, 2022
Copy link

@viniciusgbatista viniciusgbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works

@pichouk
Copy link

pichouk commented Apr 26, 2022

Fixes the issue for me too. Thanks a lot @ezequielsbarros
Now the question is : who have write access to this repository and to PyPI ? Because the last merge / release is from 15 months ago 😬

@gurumaia
Copy link

Fixes our problem as well. @stevemac007 can you get this approved?

@jindriago-scf
Copy link

Hi team, is there something we can do to help merge this PR? This solves the problem some of our engineers are having deploying to AWS.

@ezequielbarros
Copy link

Hi team, is there something we can do to help merge this PR? This solves the problem some of our engineers are having deploying to AWS.

Temporarily while this PR is not merged I have locally altered the google.py file including the two lines of code from the commit of this PR. You can direct your engineers to do the same to temporarily fix the problem.

@luizliso
Copy link

Now it wokrs! Thanks @ezequielbarros

@jeanmercierswile
Copy link

It has worked for me. 👍

@akours
Copy link

akours commented Apr 27, 2022

Works like a charm! 👍

@rdonkin-attest
Copy link

We are getting this issue a lot - this PR worked for several people to fix.

Hope this can be merged soon!

@mrmooon
Copy link

mrmooon commented Apr 27, 2022

In the meantime, while this PR gets merged, we've been able to workaround this using the Docker image, which is still working (at least for most people in our team).

@LeandroMReis
Copy link

Worked perfectly. Thanks @ezequielbarros

@LeandroMReis
Copy link

@stevemac007

@igorGevaerd
Copy link

It worked like a charm!

@yh0an
Copy link

yh0an commented Apr 27, 2022

It works thanks ❤️

@jonathanmdr
Copy link

It works! Thanks @ezequielsbarros

@KlavsKlavsen
Copy link

Soo missing a maintainer here :(

@dienp
Copy link

dienp commented Apr 28, 2022

Please merge

@pichouk
Copy link

pichouk commented Apr 28, 2022

Hi everyone :)
As you can all see this project is not maintained anymore. So I'm pretty sure that adding new approvals, "+1", or whatever will not result in anything else than sending annoying notification to everyone 😉

If someone have the time/energy to maintain a fork, or to reach a maintainer (or someone at Cevo Australia) in order to get write access to this project and to PyPi, it could be great. But I suggest to discuss this on a dedicated Github issue or on #238. Because I don't think this PR will be merged and release with the current situation.

@stevemac007 stevemac007 merged commit f139910 into cevoaustralia:master May 2, 2022
@danmoz
Copy link

danmoz commented May 3, 2022

I see we got it merged, and even a new release on PyPI -- thanks to all involved!

One last thing, does anyone have access to push an updated image to Dockerhub?

I've built and pushed up my own version at danmorrison/aws-google-auth... but I'd sure prefer to be using the "official" one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.