-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bg_response in request payload to passwd challenge #250
Add bg_response in request payload to passwd challenge #250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works
Fixes the issue for me too. Thanks a lot @ezequielsbarros |
Fixes our problem as well. @stevemac007 can you get this approved? |
Hi team, is there something we can do to help merge this PR? This solves the problem some of our engineers are having deploying to AWS. |
Temporarily while this PR is not merged I have locally altered the google.py file including the two lines of code from the commit of this PR. You can direct your engineers to do the same to temporarily fix the problem. |
Now it wokrs! Thanks @ezequielbarros |
It has worked for me. 👍 |
Works like a charm! 👍 |
We are getting this issue a lot - this PR worked for several people to fix. Hope this can be merged soon! |
In the meantime, while this PR gets merged, we've been able to workaround this using the Docker image, which is still working (at least for most people in our team). |
Worked perfectly. Thanks @ezequielbarros |
It worked like a charm! |
It works thanks ❤️ |
It works! Thanks @ezequielsbarros |
Soo missing a maintainer here :( |
Please merge |
Hi everyone :) If someone have the time/energy to maintain a fork, or to reach a maintainer (or someone at Cevo Australia) in order to get write access to this project and to PyPi, it could be great. But I suggest to discuss this on a dedicated Github issue or on #238. Because I don't think this PR will be merged and release with the current situation. |
I see we got it merged, and even a new release on PyPI -- thanks to all involved! One last thing, does anyone have access to push an updated image to Dockerhub? I've built and pushed up my own version at |
This fix resolves the issue reported on #248
When adding the --bg-response parameter, the value is not passed on in the captcha validation request, which causes a validation error.
The error occurs because google blocks the request in new installations due to the default value that informs that there is no support for javascript "bg_response" with value "js_disabled".
It is necessary to pass the value as "bg_response" with value "js_enabled" to avoid the error in the google authentication flow.
But the error continues to occur in the captcha validation because this parameter was not passed on in the challenge response payload.
By adding "bg_response" with value "js_enabled" in the challenge submission, the authentication flow proceeds normally.
This error occurs in new installations of aws-google-auth, not being reproduced in installations that already existed, I can't explain why.