Skip to content

Commit

Permalink
fix typo in suppressStorageFQDNsRender, address #580
Browse files Browse the repository at this point in the history
Signed-off-by: Artem Navoiev <[email protected]>
  • Loading branch information
tenmozes committed Jul 11, 2023
1 parent 1b20843 commit df893ce
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion charts/victoria-metrics-cluster/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v1
appVersion: v1.91.3
description: Victoria Metrics Cluster version - high-performance, cost-effective and scalable TSDB, long-term remote storage for Prometheus
name: victoria-metrics-cluster
version: 0.9.73
version: 0.9.74
sources:
- https://github.com/VictoriaMetrics/helm-charts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
securityContext:
{{- toYaml .Values.vminsert.podSecurityContext | nindent 12 }}
args:
{{- if not .Values.vminsert.suppresStorageFQDNsRender }}
{{- if not (or .Values.vminsert.suppresStorageFQDNsRender .Values.vminsert.suppressStorageFQDNsRender) }}
{{- include "victoria-metrics.vminsert.vmstorage-pod-fqdn" . | nindent 12 }}
{{- end }}
{{- range $key, $value := .Values.vminsert.extraArgs }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ spec:
{{- toYaml .Values.vmselect.podSecurityContext | nindent 12 }}
args:
- {{ printf "%s=%s" "--cacheDataPath" .Values.vmselect.cacheMountPath | quote}}
{{- if not .Values.vmselect.suppresStorageFQDNsRender }}
{{- if not (or .Values.vmselect.suppressStorageFQDNsRender .Values.vmselect.suppresStorageFQDNsRender )}}
{{- include "victoria-metrics.vmselect.vmstorage-pod-fqdn" . | nindent 12 }}
{{- end }}
{{- range $key, $value := .Values.vmselect.extraArgs }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
{{- toYaml .Values.vmselect.podSecurityContext | nindent 12 }}
args:
- {{ printf "%s=%s" "--cacheDataPath" .Values.vmselect.cacheMountPath | quote}}
{{- if not .Values.vmselect.suppresStorageFQDNsRender }}
{{- if not (or .Values.vmselect.suppressStorageFQDNsRender .Values.vmselect.suppresStorageFQDNsRender }}
{{- include "victoria-metrics.vmselect.vmstorage-pod-fqdn" . | nindent 12 }}
{{- end }}
{{- include "victoria-metrics.vmselect.vmselect-pod-fqdn" . | nindent 12 -}}
Expand Down
4 changes: 2 additions & 2 deletions charts/victoria-metrics-cluster/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ vmselect:
# -- Overrides the full name of vmselect component
fullnameOverride: ""
# -- Suppress rendering `--storageNode` FQDNs based on `vmstorage.replicaCount` value. If true suppress rendering `--storageNodes`, they can be re-defined in extraArgs
suppresStorageFQDNsRender: false
suppressStorageFQDNsRender: false
automountServiceAccountToken: true
# Extra command line arguments for vmselect component
extraArgs:
Expand Down Expand Up @@ -291,7 +291,7 @@ vminsert:
# -- Additional environment variables (ex.: secret tokens, flags) https://github.com/VictoriaMetrics/VictoriaMetrics#environment-variables
env: []
# -- Suppress rendering `--storageNode` FQDNs based on `vmstorage.replicaCount` value. If true suppress rendering `--storageNodes`, they can be re-defined in extraArgs
suppresStorageFQDNsRender: false
suppressStorageFQDNsRender: false
automountServiceAccountToken: true

# Readiness & Liveness probes
Expand Down

0 comments on commit df893ce

Please sign in to comment.