Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppresStorageFQDNsRender is misspelled in Helm Charts. #580

Closed
perfectra1n opened this issue Jul 11, 2023 · 2 comments
Closed

suppresStorageFQDNsRender is misspelled in Helm Charts. #580

perfectra1n opened this issue Jul 11, 2023 · 2 comments
Assignees

Comments

@perfectra1n
Copy link

Hey VictoriaMetrics,

Thanks for the great product. Just wanted to reach out and let you guys know that suppresStorageFQDNsRender is misspelled and it should be suppressStorageFQDNsRender unless I'm losing my sanity lol. This cost me a decent amount of time since I didn't copy and paste the key into my Helm values lol.

It's in a few places

{{- if not .Values.vmselect.suppresStorageFQDNsRender }}

suppresStorageFQDNsRender: false

tenmozes added a commit that referenced this issue Jul 11, 2023
@tenmozes
Copy link
Collaborator

hi @perfectra1n should be fixed in #581

@perfectra1n
Copy link
Author

perfectra1n commented Jul 11, 2023

oooooooh, that's gonna break some deployments for sure, just FYI if they're relying on that value

edit: OH you did an or, thank you lol

f41gh7 added a commit that referenced this issue Jul 25, 2023
* fix typo in suppressStorageFQDNsRender, address #580

Signed-off-by: Artem Navoiev <[email protected]>

* close or statement

Signed-off-by: Artem Navoiev <[email protected]>

---------

Signed-off-by: Artem Navoiev <[email protected]>
Co-authored-by: Nikolay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants