Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sideEffects: false to more packages #2910

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Conversation

xzilja
Copy link
Contributor

@xzilja xzilja commented Jun 30, 2023

Creating a release? Please use the Release PR Template instead.

Description

Added sideEffects: false field to more packages

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

No testing besides monorepo ones

Fixes/Resolves (Optional)

N/A

Examples/Screenshots (Optional)

N/A

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

N/A

@xzilja xzilja merged commit 98312c9 into v2.0 Jul 4, 2023
9 checks passed
@ganchoradkov ganchoradkov mentioned this pull request Jul 6, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants