-
-
Notifications
You must be signed in to change notification settings - Fork 204
fix: Update WalletConnectConnector to handle individual namespaces like eip155:* #391
Conversation
🦋 Changeset detectedLatest commit: 0714209 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +46 B (0%) Total Size: 52.1 kB
ℹ️ View Unchanged
|
@@ -26,6 +26,7 @@ | |||
"@safe-global/safe-apps-provider": "^0.17.1", | |||
"@safe-global/safe-apps-sdk": "^8.0.0", | |||
"@walletconnect/ethereum-provider": "2.8.6", | |||
"@walletconnect/utils": "2.8.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add sideEffects: false
to @walletconnect/utils#package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created pr for this, but not sure if we will land it this week
WalletConnect/walletconnect-monorepo#2910
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xasimetriq aren't the utils pre-bundled with ethereum-provider
? with yarn I'm sure it works without specifying the package, not sure about pnpm tho
This PR seems to be fixing for this bug report: Pls review/merge it asap Thanks |
Pr is out of sync with actual branch will close and reopen to try and get latest updates. Looks like gh bug |
@0xasimetriq |
@0xasimetriq The error is related to the usage of the hook Pls notice that this error does not occur for wagmi version |
|
@0xasimetriq Regarding point #1, if possible, pls discuss directly with Bifrost as it is the main mobile wallet on Songbird/Flare blockchain networks. Regarding point #2, that error does not occur for |
@0xasimetriq |
Description
Up until now WalletConnectConnector was set up to handle namespaces that included all data under global
eip155
key i.e.This worked as that's how majority of wallets implement the spec, however with v1 sunset we saw few wallets that return namespaces in another format (also valid)
Plus, there can be a combination of both formats returned. I updated connector to handle both when checking namespace chainId's and methods for validation.
Additional Information
Your ENS/address: asimetriq.eth