This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Rename SIMD load splats and load extends #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binji
approved these changes
Aug 25, 2020
|
Thanks for reviewing, I will hold off merging until after the discussion next sync (see #323). |
Following suggestions in WebAssembly#297, renaming load splats and load extends to something more consistent. Fixed WebAssembly#297.
ngzhian
force-pushed
the
rename-load-splat
branch
from
73051c9
to
a7f846d
Compare
ngzhian
changed the title
|
Poll to rename passed, see WebAssembly SIMD Sync 9/04/2020 section titled "2. Instruction renaming", merging. |
pull bot
pushed a commit
to Alan-love/v8
that referenced
this pull request
Sep 23, 2020
Rename opcodes based on the renaming in the proposal, WebAssembly/simd#322. Bug: v8:10946 Change-Id: If267d6f8fb1b9deeff64cd9abcd7e4cd64a540a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2422357 Commit-Queue: Zhi An Ng <[email protected]> Reviewed-by: Bill Budge <[email protected]> Cr-Commit-Position: refs/heads/master@{#70077}
This was referenced Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following suggestions in #297, renaming load splats and load extends to something more
consistent.
Fixed #297.