Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasi-sdk-11 release: 18.04 deb missing? #142

Closed
orestisfl opened this issue Jun 10, 2020 · 5 comments
Closed

wasi-sdk-11 release: 18.04 deb missing? #142

orestisfl opened this issue Jun 10, 2020 · 5 comments

Comments

@orestisfl
Copy link
Contributor

I don't see a 18.04 deb in https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-11. Is 16.04 mislabeled?

@sbc100
Copy link
Member

sbc100 commented Jun 10, 2020

I think we decided to for 16.04 for max compatibility. However you should be able to install it on 18.04.

For that matter, I don't remember why we have two deb packages here since 16.04 should work on any recent ubuntu. @pchickey do you remember?

@pchickey
Copy link
Collaborator

There's two debs provided because we build both of them as part of CI - no other reason. 16.04 is built with a docker image, and we specifically keep it pinned at that ubuntu for maximum compatibility. 20.04 is built with github CI's ubuntu-latest environment.

There is no 18.04 build. If there's a compelling reason to create one, we could use another docker image to build it for the next release.

@sbc100
Copy link
Member

sbc100 commented Jun 10, 2020

I suggest we instead just ship a single .deb (the 16.04 we build in docker). I'm hoping it should just work everywhere and we can revisit if it doesn't.

I suggest we remove the 16.04 from the name so people don't think that is the only version it works on.

@sbc100
Copy link
Member

sbc100 commented Jun 10, 2020

I just confirmed that the deb we call 16.04 works fine on by debian/testing system, for example, so it not even limited to ubuntu.

@pchickey
Copy link
Collaborator

pchickey commented Jun 10, 2020

Sounds good to me. I am hesitant to rename the files currently in the release because I (and maybe others?) already download them in CI scripts. I will instead re-upload the 16.04 one with the suffix dropped, and stick to that process in the future. I've added a note in the release text as well.

kildom pushed a commit to kildom/clang-wasi-port that referenced this issue Jul 14, 2021
* Use constructor functions for optional init routines.

Instead of using weak symbols, use constructor function attributes for the
environment and preopen initialization routines. This is simpler, uses
less code, and is more LTO-friendly.

* Change the constructor priorities to start at 50.

We don't currently have specific plans for other levels in the reserved
range (0-100), so leave room for both lower and higher priorities.
alexcrichton pushed a commit to alexcrichton/wasi-sdk that referenced this issue Apr 5, 2023
This brings in the following changes:

f645f49 Update signal macros after upgrade to snapshot1 (WebAssembly#144)
8b3266d github actions: pin checkout action to v1 (WebAssembly#145)
410c660 Use constructor functions for optional init routines. (WebAssembly#142)
fe13053 c header generation updated for reorganized witx ast (WebAssembly#139)
cd74e1d Correct the version of WebAssembly#136 on master (WebAssembly#141)
446cb3f Wasi snapshot preview1 (WebAssembly#140)
54102f0 Ignore rights in libpreopen. (WebAssembly#129)
8c9e1c6 Make the `__original_main` definition weak, fixing -flto. (WebAssembly#138)
cf81683 Optimize `fmin`, `fmax`, etc. (WebAssembly#120)
deb8eae Don't pre-check capabilities in `openat`. (WebAssembly#130)
ca9046d Use consistent style for wasi-libc C source files. (WebAssembly#131)
951cc3e Fix unintended recursion in __wasilibc_register_preopened_fd. (WebAssembly#133)
5216983 Avoid a `strdup` call in `__wasilibc_populate_libpreopen`. (WebAssembly#128)
70099d4 Don't link in libpreopen initialization code when it isn't needed. (WebAssembly#127)
ec4549d Temporarily disable the use of `__heap_base`. (WebAssembly#132)
a214f1c Use __heap_base by dlmalloc (WebAssembly#114)
a94d2d0 Avoid varargs conventions when calling open (WebAssembly#126)
7fcc4f2 Revamp and simplify the libpreopen code. (WebAssembly#110)
eb7230c Remove more unsupported headers. (WebAssembly#123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants