[DO NOT MERGE] Stage release 9 #114
Conversation
Add support for building libcxx and libcxxabi in LTO mode, along aside the regular non-LTO builds. Pass CLANG_VERSION to the wasi-libc build so that it can build itself in LTO and non-LTO modes. And drop the explicit -O1 from the compiler-rt build, and just go with the default optimization settings.
|
Any not just land those specific PRs in place? (or is this PR not for landing, just for experimenting?) |
|
I want to land those specific PRs in place, yes. I should have marked this as not for merging, and have corrected that. Aside from actually running CI, I want to run some tests locally in lucet with a representative release build, so I'm having Actions build me one rather than get my laptop hot for 2 hours. |
|
Mac CI has failed twice in a row with the exact same The Linux CI passes and the uploaded artifact seems to work correctly in my local testing. |
|
I really wish github would hurry up and add my favorite feature of circleci which is "rerun tests with SSH access to bot".. then you can just log into the failing bot and debug directly (including windows!) |
|
Yeah.. it looks like make simply returns 2 for no reported reason. Perhaps try without the |
* add explicit allocator initialization * move init to a better place * fix warnings * add __wasilibc_try_init_allocator * move initialization to dlmalloc() * fix typos * fix identations * follow style guide * review changes
This brings in the following changes: f645f49 Update signal macros after upgrade to snapshot1 (WebAssembly#144) 8b3266d github actions: pin checkout action to v1 (WebAssembly#145) 410c660 Use constructor functions for optional init routines. (WebAssembly#142) fe13053 c header generation updated for reorganized witx ast (WebAssembly#139) cd74e1d Correct the version of WebAssembly#136 on master (WebAssembly#141) 446cb3f Wasi snapshot preview1 (WebAssembly#140) 54102f0 Ignore rights in libpreopen. (WebAssembly#129) 8c9e1c6 Make the `__original_main` definition weak, fixing -flto. (WebAssembly#138) cf81683 Optimize `fmin`, `fmax`, etc. (WebAssembly#120) deb8eae Don't pre-check capabilities in `openat`. (WebAssembly#130) ca9046d Use consistent style for wasi-libc C source files. (WebAssembly#131) 951cc3e Fix unintended recursion in __wasilibc_register_preopened_fd. (WebAssembly#133) 5216983 Avoid a `strdup` call in `__wasilibc_populate_libpreopen`. (WebAssembly#128) 70099d4 Don't link in libpreopen initialization code when it isn't needed. (WebAssembly#127) ec4549d Temporarily disable the use of `__heap_base`. (WebAssembly#132) a214f1c Use __heap_base by dlmalloc (WebAssembly#114) a94d2d0 Avoid varargs conventions when calling open (WebAssembly#126) 7fcc4f2 Revamp and simplify the libpreopen code. (WebAssembly#110) eb7230c Remove more unsupported headers. (WebAssembly#123)
This merges #89 #107 #109 on top of master.
I just discovered that Github Actions was not enabled when the repo moved to its new home, so the last few PRs were merged without any CI! I have re-enabled it. Hopefully this branch will show we are all clear.