Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to subclass wasm C++ API classes for the implementor. #161

Merged
merged 28 commits into from
Nov 23, 2020
Merged

Make it possible to subclass wasm C++ API classes for the implementor. #161

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
2a82d7d
Make it possible to implement the Wasm C++ API using subclasses.
nlewycky Nov 5, 2020
1a41e0f
Update wasm-bin for C++ API changes.
nlewycky Nov 5, 2020
6165f26
WIP. Start updating V8 to the new C++ API.
nlewycky Nov 5, 2020
c8a138a
WIP. Continue implementation through ExternType to ExportType.
nlewycky Nov 6, 2020
51413ad
Fix own_cast<> to cast to the To type, not to the From type.
nlewycky Nov 9, 2020
c61f484
WIP. First pass through the whole file, excluding Shared<>.
nlewycky Nov 9, 2020
d2e5b1c
Reintroduce template implement and use it, except for the ExternType …
nlewycky Nov 10, 2020
4ebbe72
Rename "Destroyer" to "destroyer", re-add Table::size_t.
nlewycky Nov 10, 2020
31f2b9a
Update for renaming of Destroyer.
nlewycky Nov 10, 2020
3e18dbb
Make destroyer a non-template allowing us to remove own_cast.
nlewycky Nov 10, 2020
bf93f13
Remove make_own<T>(ptr), use own<T>(ptr) instead.
nlewycky Nov 10, 2020
3bc9596
Make these classes instead of structs, since they use public inherita…
nlewycky Nov 10, 2020
3b0598f
Simplify ExternTypeImpl. Use impl() to cast instead of T::from().
nlewycky Nov 11, 2020
03ccee2
Remove use of own_cast<> from wasm-bin too.
nlewycky Nov 11, 2020
4f92dd0
Cleanup changes versus master.
nlewycky Nov 11, 2020
e4fe1b7
WIP. Implement Shared<> using explicit template specialization.
nlewycky Nov 11, 2020
a84c358
Always free the v8::Persistent<object> handle in the Store.
nlewycky Nov 11, 2020
43e74c1
Don't delete v8::PersistenObject ourselves, let the V8 GC do it.
nlewycky Nov 11, 2020
99144ae
Fix static_assert to work in C++11.
nlewycky Nov 11, 2020
6929ae1
ValTypeImpl's never destroyed, only a small pool is created on startup.
nlewycky Nov 11, 2020
65a9d63
Simplify this code now that we can implicitly cast own<T>.
nlewycky Nov 11, 2020
9f28f9b
Fix bug deleting ExternTypes. Make Shared<Module>::~Shared() non-inline.
nlewycky Nov 11, 2020
225009c
Use structs, remove 'public'.
nlewycky Nov 12, 2020
eef1823
Add convenience method for creating own<T> without specifying templat…
nlewycky Nov 12, 2020
8a95d59
Define the explicit specialization for Shared<Module> in wasm.hh, wit…
nlewycky Nov 12, 2020
c937d7e
Make a SharedImpl<> that derives from vec<byte_t>.
nlewycky Nov 12, 2020
abf9aed
Forward-declare Shared, then define Shared<Module> after Module.
nlewycky Nov 19, 2020
3364581
Merge branch 'master' into use-subclasses
nlewycky Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading