Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: amount of player required at creation #276

Merged
merged 15 commits into from
Nov 26, 2022
Merged

Conversation

Segelzwerg
Copy link
Contributor

Fixes

  • Removes the field team_size from Matcher class. This field required to know the amount of players at the creation of a table. However, we allow dynamic amount of players if required. So the amount of players at the start of a table could be less than originally planned for. This changes the behavior of matchers to dynamically adapt during the request of a new distribution.

Signed-off-by: Segelzwerg <[email protected]>
Signed-off-by: Segelzwerg <[email protected]>
Signed-off-by: Segelzwerg <[email protected]>
Signed-off-by: Segelzwerg <[email protected]>
Signed-off-by: Segelzwerg <[email protected]>
Signed-off-by: Segelzwerg <[email protected]>
@Segelzwerg Segelzwerg self-assigned this Nov 25, 2022
@Segelzwerg Segelzwerg added the bug Something isn't working label Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #276 (ca00c82) into main (fdf9209) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   97.36%   97.36%   -0.01%     
==========================================
  Files          28       28              
  Lines         798      797       -1     
==========================================
- Hits          777      776       -1     
  Misses         21       21              
Impacted Files Coverage Δ
whist_core/session/matcher.py 98.07% <100.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pyproject.toml Outdated Show resolved Hide resolved
whist_core/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@iTitus iTitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this is a breaking change, so dont increase the patch version

@iTitus iTitus merged commit c6e759d into main Nov 26, 2022
@iTitus iTitus deleted the fix/pre_set_amount_of_players branch November 26, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants