FIX: min max player in room

[Segelzwerg]

Requires

• FIX: Minimum player must be higher than maximum player Whist-Core#256 to be released
• BUG: matcher not being parsed Whist-Core#261 to be closed.
• FIX: dict conversion Whist-Core#265
• FIX: amount of player required at creation Whist-Core#276

Fixes #375

Breaking Change:

Matcher in table cannot be parsed in:

@classmethod
def create_with_pwd(cls, room_name: str, creator: Player, hashed_password: Optional[str] = None,
                    min_player: Optional[int] = None,
                    max_player: Optional[int] = None) -> 'RoomInDb':
    """
    Factory method to create a Room in database object.
    :param room_name: name of this session
    :param creator: player object of the host
    :param hashed_password: the hash value of the password required to join
    :param min_player: the minimum amount of player to start a room
    :param max_player: the maximum amount of player that can join this session
    :return: the Room object
    """
    min_player = 4 if min_player is None else int(min_player)
    max_player = 4 if max_player is None else int(max_player)
    room = RoomInDb.create(room_name, creator, min_player, max_player)
    return RoomInDb(**room.dict(exclude={'table': {'matcher'}}),
                    hashed_password=hashed_password)

See Whist-Team/Whist-Core#261 for details.

[codecov]

Codecov Report

Merging #377 (247d5d9) into main (2c3e978) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files          39       39           
  Lines         960      960           
=======================================
  Hits          928      928           
  Misses         32       32           

Impacted Files	Coverage Δ
whist_server/api/room/action.py	100.00% <100.00%> (ø)
whist_server/api/room/create.py	100.00% <100.00%> (ø)
whist_server/database/room.py	98.91% <100.00%> (+0.03%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Segelzwerg]

I have to revisit this one. May take a while.