OneObjectStructurePerFile: move from Extra to Core
#1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd say leave it as an error. I think the proposed message for Core is friendlier than the default upstream. |
jrfnl
force-pushed
the
feature/move-one-object-per-class-to-core
branch
from
9ed06a8
to
bc61afb
Compare
I've updated the PR to leave the message at an This rule still needs to be added to the WP/Core CS Handbook. Any volunteers ? /cc @pento |
GaryJones
approved these changes
Oct 16, 2019
dingo-d
approved these changes
Oct 17, 2019
|
I'd merge this after the handbook is updated, is this ok? |
jrfnl
force-pushed
the
feature/move-one-object-per-class-to-core
branch
from
bc61afb
to
6573b97
Compare
jrfnl
force-pushed
the
feature/move-one-object-per-class-to-core
branch
from
6573b97
to
30cb490
Compare
Per the discussion had on Slack about this initiated by GaryJones. WP Core currently has 27 violations against this rule. In `Extra` the error message was changed and downgraded to a `warning`. Now the sniff will be added to `Core`, per this PR, the: * Message text will still be changed a little to be clearer, but will be stricter. * The message will be an `error` and not be downgraded to a `warning`. To do: - [ ] Add a rule to this effect to the handbook.
jrfnl
force-pushed
the
feature/move-one-object-per-class-to-core
branch
from
30cb490
to
88c5608
Compare
|
Rebased to have the GH Actions checks run. |
dingo-d
added a commit
to WordPress/wpcs-docs
that referenced
this pull request
Apr 9, 2021
This addition will allow WordPress/WordPress-Coding-Standards#1802 to be merged to the coding standards. This will encourage having one class/interface/trait per file.
|
I've opened a PR for the handbook, so once that is merged we can merge this PR as well. |
jrfnl
pushed a commit
to WordPress/wpcs-docs
that referenced
this pull request
Apr 12, 2021
* Adding one object structure per file This addition will allow WordPress/WordPress-Coding-Standards#1802 to be merged to the coding standards. This will encourage having one class/interface/trait per file.
HoneyRole
added a commit
to HoneyRole/WPCSDOC
that referenced
this pull request
Nov 22, 2022
* Adding one object structure per file This addition will allow WordPress/WordPress-Coding-Standards#1802 to be merged to the coding standards. This will encourage having one class/interface/trait per file.
prodev515
pushed a commit
to prodev515/VMprotect
that referenced
this pull request
Dec 15, 2023
* Adding one object structure per file This addition will allow WordPress/WordPress-Coding-Standards#1802 to be merged to the coding standards. This will encourage having one class/interface/trait per file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling this after @GaryJones brought this up as a suggestion on Slack.
WP Core currently has 27 violations against this rule - 3 in
src, the rest intests.All the same, it would be a good thing to move this sniff to the
Coreruleset. /cc @pentoOpen questions:
Extraconfiguration downgraded this to awarning. Should this be anerroror awarningnow it's moving toCore?Extraconfiguration also adjusted the error message. Is this still necessary or should we just use the default message from the sniff ?Only one object structure is allowed in a file.ExtraBest practice suggestion: Declare only one class/interface/trait in a file.CoreBest practices: Declare only one class/interface/trait in a file.To do before this can be merged:
Coreruleset to place the sniff in the right place with the text from the handbook.