-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding one object structure per file #52
Conversation
This addition will allow WordPress/WordPress-Coding-Standards#1802 to be merged to the coding standards. This will encourage having one class/interface/trait per file.
For the record - this is how it was announced in the blog post about coding standards on Make last year:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dingo-d Thanks for doing this! Text looks good to me.
It does feel a bit "off" for this to be lumped in into the "Naming Conventions" section though, so I suggest adding it as its own section just below that one.
Other than that, just some punctuation fixes to be made and it is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, add @jrfnl suggestions and feel free to merge
Co-authored-by: Juliette <[email protected]>
Co-authored-by: Juliette <[email protected]>
Co-authored-by: Juliette <[email protected]>
Co-authored-by: Juliette <[email protected]>
Co-authored-by: Juliette <[email protected]>
Co-authored-by: Juliette <[email protected]>
Thanks for the suggestions 👍🏼 I wasn't sure if this should have its own subchapter or not, so I just placed them at the end of the naming part, because that's closest to the issue (the way files should be named and all). But it does make more sense to be on its own. I've committed the changes you've suggested, so this can be merged 🙂 |
This addition will allow WordPress/WordPress-Coding-Standards#1802 to be merged to the coding standards.
This will encourage having one class/interface/trait per file.
Feel free to suggest better wording, I tried to be as clear as possible.