Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable avoidEscape in eslint string config so we can avoid escaping single quotes #7366

Closed
tofumatt opened this issue Jun 19, 2018 · 0 comments · Fixed by #7555
Closed

Enable avoidEscape in eslint string config so we can avoid escaping single quotes #7366

tofumatt opened this issue Jun 19, 2018 · 0 comments · Fixed by #7555
Assignees
@tofumatt
Labels
[Type] Code Quality Issues or PRs that relate to code quality

Comments

@tofumatt
Copy link
Member

tofumatt commented Jun 19, 2018 •
edited
Loading

This is just an eslint/code quality issue. I've noticed we force single quotes at all times, even when the string contains a single quote. This means we write 'It\'s my birthday!' rather than "It's my birthday!". The latter is way more readable, fewer things to type, etc.

It's totally nicer and eslint supports this setting (avoidEscape ), so we should use it.
@tofumatt tofumatt added the [Type] Code Quality Issues or PRs that relate to code quality label Jun 19, 2018
@tofumatt tofumatt mentioned this issue Jun 19, 2018
Merged
@tofumatt tofumatt mentioned this issue Jun 26, 2018
Merged
4 tasks
tofumatt added a commit that referenced this issue Jun 26, 2018
@tofumatt
chore: Allow double quotes when strings contain single quotes
c500c09 
Fixes #7366
@tofumatt tofumatt self-assigned this Jun 26, 2018
tofumatt added a commit that referenced this issue Jun 26, 2018
@tofumatt
chore: Change escaped single-quoted strings after #7366
87b1672
This was referenced Jun 26, 2018
Merged
Merged
tofumatt added a commit that referenced this issue Jul 24, 2018
@tofumatt
chore: Allow double quotes when strings contain single quotes
edbbc5a 
Fixes #7366
tofumatt added a commit that referenced this issue Jul 24, 2018
@tofumatt
chore: Change escaped single-quoted strings after #7366
2d10143
tofumatt added a commit that referenced this issue Jul 25, 2018
@tofumatt
Allow double quotes and template string sometimes (#7555)
804abec 
* chore: Allow double quotes when strings contain single quotes

Fixes #7366
@petrescugit petrescugit mentioned this issue Dec 25, 2023
Open
@npneeraj npneeraj mentioned this issue Dec 25, 2023
Open
@yaseenaljamal yaseenaljamal mentioned this issue Dec 25, 2023
Open
@naiba4 naiba4 mentioned this issue Dec 25, 2023
Open
@yassine4999 yassine4999 mentioned this issue Dec 25, 2023
Open
@captainbarber99 captainbarber99 mentioned this issue Dec 25, 2023
Open
@soloinovator soloinovator mentioned this issue Dec 25, 2023
Open
@MaxMood96 MaxMood96 mentioned this issue Dec 26, 2023
Open
This was referenced Dec 26, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow double quotes and template string sometimes WordPress/gutenberg
1 participant
@tofumatt