Parser: Fix boolean attribute explicit string value result #7610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
tofumatt
approved these changes
Jun 28, 2018
| @@ -19,6 +19,22 @@ import { isValidBlock } from './validation'; | |||
| import { getCommentDelimitedContent } from './serializer'; | |||
| import { attr, prop, html, text, query, node, children } from './matchers'; | |||
|
|
|||
| /** | |||
| * Higher-order hpq matcher which enhances an attribute matcher to return true | |||
blocks/api/parser.js
Outdated
| * | ||
| * @param {Function} matcher Original hpq matcher. | ||
| * | ||
| * @return {Function} Enhanced hpq matcher.`` |
There was a problem hiding this comment.
Not sure what the backticks at the end are for 🤷♂️
There was a problem hiding this comment.
Not sure what the backticks at the end are for 🤷♂️
Fat fingered 😄
blocks/api/parser.js
Outdated
| */ | ||
| export const toBooleanAttributeMatcher = ( matcher ) => flow( [ | ||
| matcher, | ||
| ( value ) => value !== undefined, |
There was a problem hiding this comment.
I almost asked "what about a false value?" but that should never happen. Not sure if it's worth adding docs just to remind the reader about that.
| @@ -132,6 +174,19 @@ describe( 'block parser', () => { | |||
| expect( value ).toBe( true ); | |||
| } ); | |||
|
|
|||
| it( 'should return the matcher\'s true boolean attribute value on explicit attribute value', () => { | |||
There was a problem hiding this comment.
This is definitely a case where I'm like #7366 for the win 😉
|
Nice, I love the table 👍 |
|
Thanks @aduth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #7322
This pull request seeks to fix an issue in the implementation of #7322 where an explicit string value assigned as an attribute would be wrongly interpreted as
falsewhen assigned as abooleanattribute type. Both<input disabled>and<input disabled="disabled">should returntruefor a boolean attribute source type.Testing instructions:
Ensure unit tests pass:
Repeat testing instructions from #7322.