Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on "Post Settings" should not deselect a block #827

Closed
mtias opened this issue May 17, 2017 · 3 comments · Fixed by #836
Closed

Clicking on "Post Settings" should not deselect a block #827

mtias opened this issue May 17, 2017 · 3 comments · Fixed by #836
Assignees
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@mtias
Copy link
Member

mtias commented May 17, 2017

When a block is selected, clicking on post settings is meant to open the inspector for that block, so it should not be deselected in the process. Also, clicking on the panel should not deselect the block.

Thinking of it, maybe only clicking on the white canvas of the editor deselects a block, not the toolbar or the sidebar.

@mtias mtias added General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take labels May 17, 2017
@jasmussen
Copy link
Contributor

Thinking of it, maybe only clicking on the white canvas of the editor deselects a block, not the toolbar or the sidebar.

👍

See also #657, #669 and #712.

@aduth
Copy link
Member

aduth commented May 17, 2017

Thinking of it, maybe only clicking on the white canvas of the editor deselects a block, not the toolbar or the sidebar.

What does this mean in less clicky-cursor terminology? Currently, selection is bound to focus entering and leaving the block. Moving between adjacent blocks shifts selection because of a sequence of focus leaving the previous block and focus entering the next block. This works both for clicking but importantly also for tab navigation. So when we say we want selection to be more sticky, what is it exactly that we want to happen? That a block isn't unselected when focus leaves? How does tab navigation work in this scenario, since it would never deselect a block?

@mtias
Copy link
Member Author

mtias commented May 18, 2017

It means that the concepts of "selected block" and "focused block" should be two slightly different ones, because if a block is focused and you click on the "post settings" item, we should lose focus but not selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants