Chrome: Show block inspector when a block is selected #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
General Interface
|
Works great! I love it. Exactly what I imagined. Would be good to have this in soon so we can test. Not necessary for this branch, and it's blocked on #827: the underline in this mockup should actually be a clickable link, and clicking it should deselect any selected block:
The idea is that it's a breadcrumb, and clicking it takes you back to post settings. 👍 👍 |
|
Thanks for the review @jasmussen I've updated the breadcrumb to unselect the post when we click "Post". I'll leave the "Post Settings" issue opened since this has other "focus" implications and would be good to tackle separately. |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR shows the block inspector when a block is selected. If it's not the case, the post settings are shown in the sidebar.