WIP: Resizable HTML block. #14730
Closed
WIP: Resizable HTML block. #14730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolad
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
ellatrix
requested changes
Apr 2, 2019
ellatrix
added
[Block] HTML
|
@nicolad It looks like this PR could use a design review. Would it be possible for you to rebase so we can test it out |
Hi @sarahmonster, I've synced this branch with master, thx for letting me know. |
|
I've just tested this and didn't notice any resizing abilities. Am I missing something here?
Maybe we can make this block react similarly to the recent Shortcode block changes? The Shortcode block grows as text is typed to a limited height. Once the height reaches 250px it stops growing and just adds a scroll ability. Would that work better? *Sorry, I clicked the wrong button there. I didn't mean to close this PR. |
…ctor (#15701) * Rename variables for clarity in inline paste * Update selection via onSelectionUpdate after inline paste * Remove unused forceSelectionUpdate function
…15878) * Focus RichText on mount if block is selected and says so Some blocks have multiple RichText or a RichText among other children. Example: Quote blocks has 2 RichTexts and Image block has a RichText for the caption. We want to control when and which of those RichTexts will request focus. On the web side, the DOM is used to search for a inputbox to focus but on RN, we don't have a DOM to search. Instead, this commit makes the assumption that a RichText always request focus if its parent has passed `true` in `isSelected` and only if the parent hasn't inhibited that behavior by using the `noFocusOnMount` prop. * Simplify the passing of noFocusOnMount * Fix grammar in comment * Rename prop to mark it as unstable
* Fix menu item colors Fixes #15387 This PR fixes an inconsistency in menu item colors. There were some redundant CSS that had not been cleaned up properly with the move to the color mixins. Additionally it replaces the use of opacity for the lighter text in the menus, and uses the color variables instead, as those colors do not need to work on differently colored backgrounds, just white. * Address feedback.
* Move misplaced editor styles to editor.css * Add comment & rename files.
…gn (#16035) * Block library: Refactor Heading block to use class names for text align * Fix Heading icon in the collapsed mode * Add missing label for the level dropdown menu * Block library: Revert attribute name change for text align * Remove code which moves text alignment control to the block toolbar
* [Mobile] Disable Video block on Android for v1.7.0 release (#16149) * Disable Video block on Android for v1.7.0 release * Add import statement to check platform * [RNMobile] Narrow down blur on unmount to replaceable only (#16151) * Remove focus from RichText when unmounting In #15999 this behavior was changed to prevent the keyboard from disappearing when you press Enter to create a new paragraph. This worked in that case, but had the side effect of TextInputState still thinking a dead view had focus, and causing a crash in some scenarios. * Only blur a RichText in replaceable block That RichText won't have the chance to blur earlier so, we need to do it on unmount. But, non replaceable blocks wont need to blur their RichText on unmount because that will happen normally in componentDidUpdate(). * Rename to an unstable, very goal-named name * Compute shouldBlurOnUnmount inside RichText * Fix no-duplicate-imports lint issue * Fix comma-dangle lint error * Remove trailing space from comment
…6089) * Update video player to open the URL by browser * Render play button even if video is not ready to play yet * Add/update alert messages * Revert back warn to error * Do not show play button until video player has a height * Resolve merge conflicts that re-introduced a removed file
* Fixes #14180. Makes the icons grayscale. * Added an important to the style to increase strictness. Applied max height to html block.
nicolad
requested review from
adamsilverstein,
aduth,
atimmer,
chrisvanpatten,
daniloercoli,
karmatosed,
mapk,
mkaz,
mmtr,
nerrad,
oandregal,
ntwb,
SergioEstevao,
swissspidy and
TimothyBJacobs
as code owners
nicolad
added
the
[Status] Not Implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #8245
Checklist: