Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native: object fallback for element.style #19196

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Native: object fallback for element.style #19196

merged 1 commit into from
Dec 17, 2019

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Dec 17, 2019 •
edited
Loading

Description

Fixes #19097 (comment). JSDom sets the style property to null.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@ellatrix ellatrix mentioned this pull request Dec 17, 2019
Merged
6 tasks
@ellatrix ellatrix requested a review from hypest December 17, 2019 11:14
@hypest
Copy link
Contributor

hypest commented Dec 17, 2019

Gutenberg-mobile PR to have CI run the device native tests: wordpress-mobile/gutenberg-mobile#1690

@hypest hypest mentioned this pull request Dec 17, 2019
Closed
2 tasks
hypest
hypest approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @ellatrix , LGTM!

@ellatrix ellatrix merged commit fedda9f into master Dec 17, 2019
@ellatrix ellatrix deleted the fix/js-dom-style branch December 17, 2019 14:08
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
@hypest hypest mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ellatrix @hypest @youknowriad