Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate fixes to some recent regressions #1690

Closed
wants to merge 1 commit into from

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Dec 17, 2019

Update Gutenberg ref to incorporate fixes to some recent regressions

Fixes included for the following regressions:

  1. Paste: apply active formats when pasting inline WordPress/gutenberg#14815 (comment) (Gutenberg PR)
  2. Convert to blocks: preserve alignment WordPress/gutenberg#19097 (comment) (Gutenberg PR)

To test:

CI should be green.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ellatrix
Copy link
Collaborator

Is there any way these tests can be run for Gutenberg?

@ellatrix
Copy link
Collaborator

Asking because, even if native files were updated, there's no way to know for sure if everything works correctly.

@hypest
Copy link
Contributor Author

hypest commented Dec 18, 2019

👋 @ellatrix , assuming you mean running them in the Gutenberg repo, I guess we are not there yet, but we are heading that way, to incorporate native mobile e2e tests into the Gutenberg repo.

In the meantime, may I take this opportunity to suggest that, it would be useful if at least for changes in the RichText components you open PRs here in the mobile repo to test and merge? To do so, It basically boils down to updating the Gutenberg git submodule to point to the desired Gutenberg commit and push a branch and PR it. Happy to elaborate more if needed. WDYT?

@hypest
Copy link
Contributor Author

hypest commented Dec 18, 2019

This PR is not needed anymore since the latest from Gutenberg was brought in by #1631.

@hypest hypest closed this Dec 18, 2019
@hypest hypest deleted the incorporate-gb-web-fixes branch December 18, 2019 08:56
@ellatrix
Copy link
Collaborator

@hypest Sure, would love to do it for the bigger rich text PRs. Looking forward to have those tests in the main repo though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants