Enable custom classnames on <CustomSelectControl> options
#23045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
12 tasks
|
Size Change: +2 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
frontdevde
approved these changes
Jun 10, 2020
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to set a custom
classattribute on the individual options in the<CustomSelectControl>component.Previously adding a
styleattribute was already possible, but in certain circumstances, this was insufficient when needing to add complex styling rules to individual options.How has this been tested?
Manual testing and adding to Storybook example.
Tricky to test as the dropdown is added/remove from the DOM when you toggle the control. Therefore we need to use the browser debugger to "pause" the DOM with the dropdown in the open state!
To test:
npm run storybook:dev.setTimeout(() => { debugger; }, 5000)and hitENTER.Elementspanel in devtools.lielement. Look for the newclassattributecan-apply-custom-class-to-option(see screenshot above).Types of changes
New feature (non-breaking change which adds functionality).
Checklist: