Block Directory: Fix installing blocks

[TimothyBJacobs]

Description

I broke block directory inserting on master after #22454 was committed. This should fix those errors.

A block installation error is now expressed by returning an error response,
this means looking for a success property no longer works since we are
returning the installed plugin information instead.

Also switches to making an OPTIONS request to the search controller instead
of making an "empty" search request as a search term is now required.

How has this been tested?

Tested manually by opening the block directory inserter, searching for "peculiar" and installing the returned block.

Types of changes

Bug Fix

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[TimothyBJacobs]

I was able to fix the unit test error, but I'm struggling to figure out how to fix the end to end test failure. AFAICT, it's breaking here:

// Grab the first block in the list -> Needs to be the first one, the mock response expects it.
const addBtn = await page.waitForSelector(
	'.block-directory-downloadable-blocks-list li:first-child button'
);

I think the search is working. But I don't know how to debug further.

[ryelle]

If you're running it locally, you can use --puppeteer-interactive to watch the test. It looks like the permissions request isn't mocked, so it's failing that check & displays the "Please contact your site administrator to install new blocks." message.

[TimothyBJacobs]

Aha! Thanks for the tip @ryelle! Working on a fix.

[TimothyBJacobs]

Looks like that fixed it, I'm not sure if I went about it the correct way. But I didn't see other examples of mocking headers, and didn't want to touch the e2e-test-utils package. The PHPUnit tests are failing for an unrelated reason.

[TimothyBJacobs]

Test suite is now passing.

[StevenDufresne]

Thanks for fixing this! :)

[StevenDufresne]

I think it makes sense to have this here until we are out of experimental status and move to:

gutenberg/packages/core-data/src/resolvers.js

Line 171 in f15b91c

export function* canUser( action, resource, id ) {

[StevenDufresne]

Test suite is now passing.

Running it interactively seems to work. There is a warning being thrown failing my tests locally but I don't think its related to the block directory.

["Warning: React does not recognize the `%s` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `%s` instead. If you accidentally passed it from a parent component, remove it from the DOM element.%s isSelected isselected·
        in button (created by ForwardRef)
        in h (created by ForwardRef)
        in ForwardRef
        in Unknown (created by Context.Consumer)
        in WithPluginContext(Component)
        in div (created by r)
        in r (created by Context.Consumer)
        in v (created by S)
        in S
        in Unknown (created by ar)
        in div (created by ar)
        in div (created by ar)
        in ar (created by dn)
        in div
        in div
        in Unknown (created by NavigateRegions(Component))
        in div (created by NavigateRegions(Component))
        in NavigateRegions(Component) (created by dn)
        in div (created by h)
        in h (created by dn)
        in dn (created by n)
        in r (created by n)
        in Unknown
        in Unknown (created by Context.Consumer)
        in WithRegistryProvider(Component) (created by r)
        in Hn (created by r)
        in Gt (created by r)
        in Gt (created by r)
        in r (created by WithDispatch(r))
        in WithDispatch(r)
        in Unknown (created by WithSelect(WithDispatch(r)))
        in WithSelect(WithDispatch(r))
        in Unknown (created by Context.Consumer)
        in WithRegistryProvider(WithSelect(WithDispatch(r))) (created by n)
        in div (created by r)
        in r (created by n)
        in k (created by r)
        in r (created by n)
        in StrictMode (created by n)
        in n (created by WithDispatch(n))
        in WithDispatch(n)
        in Unknown (created by WithSelect(WithDispatch(n)))
        in WithSelect(WithDispatch(n))"],["Warning: React does not recognize the `%s` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `%s` instead. If you accidentally passed it from a parent component, remove it from the DOM element.%s isSelected isselected·
        in button (created by ForwardRef)
        in h (created by ForwardRef)
        in ForwardRef
        in Unknown (created by Context.Consumer)
        in WithPluginContext(Component)
        in div (created by r)
        in r (created by Context.Consumer)
        in v (created by S)
        in S
        in Unknown (created by ar)
        in div (created by ar)
        in div (created by ar)
        in ar (created by dn)
        in div
        in div
        in Unknown (created by NavigateRegions(Component))
        in div (created by NavigateRegions(Component))
        in NavigateRegions(Component) (created by dn)
        in div (created by h)
        in h (created by dn)
        in dn (created by n)
        in r (created by n)
        in Unknown
        in Unknown (created by Context.Consumer)
        in WithRegistryProvider(Component) (created by r)
        in Hn (created by r)
        in Gt (created by r)
        in Gt (created by r)
        in r (created by WithDispatch(r))
        in WithDispatch(r)
        in Unknown (created by WithSelect(WithDispatch(r)))
        in WithSelect(WithDispatch(r))
        in Unknown (created by Context.Consumer)
        in WithRegistryProvider(WithSelect(WithDispatch(r))) (created by n)
        in div (created by r)
        in r (created by n)
        in k (created by r)
        in r (created by n)
        in StrictMode (created by n)
        in n (created by WithDispatch(n))
        in WithDispatch(n)
        in Unknown (created by WithSelect(WithDispatch(n)))
        in WithSelect(WithDispatch(n))"]

[TimothyBJacobs]

I got that error message as well.

[ryelle]

Looks good & is working correctly now. FWIW I'm seeing the " React does not recognize the %s prop on a DOM element" console error on master too, so it's not an issue from this PR.