Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Block: Fix errors reported by CSS linter in ESNext template #23188

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Jun 16, 2020

Description

When running the command for linting CSS in the scaffolded block I see the following errors reported:

$ npm run lint:css
src/editor.scss
 8:21  ✖  Unexpected named color "red"   color-named

src/style.scss
 10:9  ✖  Unexpected named color "white"   color-named

This PR fixes those issues by using hex values.

How has this been tested?

$ npx wp-create-block my-test-block
$ cd my-test-block
$ npm run lint:css

Follow-up task

We really need some CI integration that would ensure that those scripts in scaffolded blocks pass :)

@gziolo gziolo self-assigned this Jun 16, 2020
@gziolo gziolo requested review from ntwb and ocean90 June 16, 2020 06:00
@gziolo gziolo added [Tool] Create Block /packages/create-block [Type] Bug An existing feature does not function as intended labels Jun 16, 2020
@github-actions
Copy link

github-actions bot commented Jun 16, 2020

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.27 kB 0 B
build/block-directory/style-rtl.css 892 B 0 B
build/block-directory/style.css 892 B 0 B
build/block-editor/index.js 106 kB 0 B
build/block-editor/style-rtl.css 12.1 kB 0 B
build/block-editor/style.css 12.1 kB 0 B
build/block-library/editor-rtl.css 7.88 kB 0 B
build/block-library/editor.css 7.89 kB 0 B
build/block-library/index.js 129 kB 0 B
build/block-library/style-rtl.css 7.96 kB 0 B
build/block-library/style.css 7.96 kB 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 195 kB 0 B
build/components/style-rtl.css 19.5 kB 0 B
build/components/style.css 19.5 kB 0 B
build/compose/index.js 9.32 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.44 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.17 kB 0 B
build/edit-navigation/index.js 8.26 kB 0 B
build/edit-navigation/style-rtl.css 975 B 0 B
build/edit-navigation/style.css 974 B 0 B
build/edit-post/index.js 302 kB 0 B
build/edit-post/style-rtl.css 5.6 kB 0 B
build/edit-post/style.css 5.6 kB 0 B
build/edit-site/index.js 16.6 kB 0 B
build/edit-site/style-rtl.css 2.96 kB 0 B
build/edit-site/style.css 2.96 kB 0 B
build/edit-widgets/index.js 9.34 kB 0 B
build/edit-widgets/style-rtl.css 2.4 kB 0 B
build/edit-widgets/style.css 2.4 kB 0 B
build/editor/editor-styles-rtl.css 423 B 0 B
build/editor/editor-styles.css 423 B 0 B
build/editor/index.js 44.8 kB 0 B
build/editor/style-rtl.css 4.26 kB 0 B
build/editor/style.css 4.27 kB 0 B
build/element/index.js 4.64 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.13 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

Copy link
Member

@ocean90 ocean90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some tests to make sure that future changes to scripts/ESLint plugin can be detected earlier?

@gziolo
Copy link
Member Author

gziolo commented Jun 16, 2020

Should we add some tests to make sure that future changes to scripts/ESLint plugin can be detected earlier?

You are reading my mind, I'm refactoring Create Block to make installation of @wordpress/scripts optional so we could do the following as GitHub action:

npm i
npx wp-create-block esnext-test --no-wp-scripts
cd esnext-test
../node_modules/.bin/wp-scripts format-js
../node_modules/.bin/wp-scripts lint-js
../node_modules/.bin/wp-scripts lint-css
../node_modules/.bin/wp-scripts build

I'm proposing the usage of the Gutenberg local packages here to ensure that scaffolded block works with the recent version of all WordPress packages, not the one published to npm

Yet another step to ensure everything works as intended would be to scaffold the block and run e2e test that inserts it into the editor.

@gziolo gziolo merged commit 78ea4fd into master Jun 16, 2020
@gziolo gziolo deleted the fix/create-block-css-lint branch June 16, 2020 07:54
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 16, 2020
@gziolo
Copy link
Member Author

gziolo commented Jun 16, 2020

Now, I have #23195 opened which proposes integration testing. I still want to find a way to run it standalone in the local environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tool] Create Block /packages/create-block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants