Refactor header toolbar items to use @wordpress/data hooks #23315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
added
[Package] Block editor
diegohaz
added
[Package] Editor
|
Size Change: -104 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Comment on lines
+13
to
+14
| select( 'core/editor' ).hasEditorRedo() | ||
| ); |
There was a problem hiding this comment.
Noting that you forgot to add a dependency array to this and the other useSelect calls to memoize the callbacks.
There was a problem hiding this comment.
Oh, thanks for noticing! I'll create a follow-up PR.
There was a problem hiding this comment.
We really need a lint rule, it’s impossible to catch all cases in review.
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor suggested by @gziolo on #22354 (comment)
How to test?
Check if Undo/Redo and the Table Of Contents buttons on the header toolbar are working properly.