Fix Slash Inserter position #29288
Merged
Fix Slash Inserter position #29288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
cameronvoell and
ellatrix
as code owners
7 tasks
|
Size Change: +17 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
I just did a quick test and this fixes the drag and drop exception in the gallery refactor PR that happened after #28917. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29262
Fix regression introduce in #28917 (comment)
Alternative to #29188
The components receiving refs shouldn't be assuming the type of ref they receive, they should instead use their own local refs. This is an error that existed in the components for some time now, but I believe it's the right fix for these issues.
Testing instructions