Fix Cover block ref usage #29354
Merged
Fix Cover block ref usage #29354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
stokesman
requested review from
youknowriad
and removed request for
ajitbohra
youknowriad
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same vein as #29288 (comment)
In this case, the ref assumption causes an error and breaks updating of the focal point in a cover block with a repeated background (other background types are fine).
This is a pretty obscure thing but I put this in the same milestone as #28917 which had the change that necessitates this.
How has this been tested?
Putting a cover block in a post, adding a repeated background and verifying the focal point adjustment works and the console is free of errors.
Screenshots
Repeated background focal point adjustment
Types of changes
Bug fix
Checklist: