Fixed color picker width #3120
Merged
Fixed color picker width #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Feature] Inspector Controls
jorgefilipecosta
requested review from
youknowriad,
gziolo,
mcsf,
ellatrix and
jasmussen
|
Thanks for the PR & screenshots. Is there any way you can avoid using |
|
Hi @jasmussen, yes I agree important should be avoided, in this PR we are removing the rule and the important usage. I tested both paragraph and button and it looks like this rule can be safely discarded. |
|
My apologies, I don't know how I mistook that red color for green. Yes, glad to see the !important gone. |
|
Hi @jasmussen no problem :) Let me know your thougths and if you feel is ok to merge this fix. |
jasmussen
approved these changes
Oct 24, 2017
…he correct width.
jorgefilipecosta
force-pushed
the
fix/color-picker-width
branch
from
77fc440
to
cb32497
Compare
|
Thank you @jasmussen it was merged! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a color picker problem that I detect recently. To reproduce the bug just go to the paragraph and try to set a custom color.
Description
It removes a rule that overrides the normal width of the custom color picker.
Screenshots:
Before:
After:
Notes
In my environment, this fixed the problem, but maybe the problem is something specific to my environment if yes I will try to find the reason why in my machine the color picker in the master appears wrong.
This problem is not happening on my machine on an external install with the last release.