-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Editor: Remove aria-selected
from LinkPreview
#43279
Conversation
Size Change: +279 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
@@ -68,6 +68,7 @@ export default function LinkPreview( { | |||
'is-preview': true, | |||
'is-error': isEmptyURL, | |||
} ) } | |||
role="option" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly sure what's going on in this part of the component, because <LinkPreview>
never seems to be contained in a listbox
. Could it be the aria-selected
part that's unnecessary, perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I've taken a look at the component in action and it doesn't seem to behave as an option in a listbox either.
I've removed the role and the aria-selected
as you suggested and fixed the test in c14c0c6.
Feel free to take another look when you get a chance.
LinkPreview
aria-selected
from LinkPreview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these follow-ups!
What?
This PR removes
aria-selected
from theLinkPreview
component as discussed in here and later in this PR.Why?
Using
aria-selected
should not be used without a role according to the guidelines.How?
We're specifically removing
aria-selected
and reflecting the change in a test.Testing Instructions
Verify all tests still pass.