Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor: Remove aria-selected from LinkPreview #43279

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Block Editor: Remove aria-selected from LinkPreview #43279

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f202155
Block Editor: Fix LinkPreview role
tyxla Aug 16, 2022
c14c0c6
Remove role and aria-selected and fix test
tyxla Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/block-editor/src/components/link-control/link-preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ export default function LinkPreview( {
'is-preview': true,
'is-error': isEmptyURL,
} ) }
role="option"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure what's going on in this part of the component, because <LinkPreview> never seems to be contained in a listbox. Could it be the aria-selected part that's unnecessary, perhaps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I've taken a look at the component in action and it doesn't seem to behave as an option in a listbox either.

I've removed the role and the aria-selected as you suggested and fixed the test in c14c0c6.

Feel free to take another look when you get a chance.

>
<div className="block-editor-link-control__search-item-top">
<span className="block-editor-link-control__search-item-header">
Expand Down
4 changes: 2 additions & 2 deletions packages/block-editor/src/components/link-control/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,8 @@ describe( 'Basic rendering', () => {
/>
);

const linkPreview = screen.queryByRole( 'generic', {
name: 'Currently selected',
const linkPreview = screen.queryByRole( 'option', {
selected: true,
} );

const isPreviewError = linkPreview.classList.contains( 'is-error' );
Expand Down