[RNMobile] Ensure text input field is not editable when Bottom sheet cell is disabled #51567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 46d0404. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5288231132
|
4 tasks
fluiddot
added a commit
that referenced
this pull request
Jun 16, 2023
* Release script: Update react-native-editor version to 1.97.0 * Release script: Update with changes from 'npm run core preios' * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md Fix white space * Release script: Update react-native-editor version to 1.97.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix crash when using the delete key to remove a single button (#51435) * Fix crash when using the delete key to remove a single button * Add onDeleteBlock prop to block.native.js * Update button edit.native.js snapshots * Update button delete test to focus button input * Update button test to use triggerBlockListLayout * [RNMobile] Ensure text input field is not editable when Bottom sheet cell is disabled (#51567) * Update `react-native-editor` changelog --------- Co-authored-by: jhnstn <[email protected]> Co-authored-by: Jason Johnston <[email protected]> Co-authored-by: Derek Blank <[email protected]>
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Release script: Update react-native-editor version to 1.97.0 * Release script: Update with changes from 'npm run core preios' * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md Fix white space * Release script: Update react-native-editor version to 1.97.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix crash when using the delete key to remove a single button (WordPress#51435) * Fix crash when using the delete key to remove a single button * Add onDeleteBlock prop to block.native.js * Update button edit.native.js snapshots * Update button delete test to focus button input * Update button test to use triggerBlockListLayout * [RNMobile] Ensure text input field is not editable when Bottom sheet cell is disabled (WordPress#51567) * Update `react-native-editor` changelog --------- Co-authored-by: jhnstn <[email protected]> Co-authored-by: Jason Johnston <[email protected]> Co-authored-by: Derek Blank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #50665
What?
Fixes an issue where the
TextInputcomponent was still editable on Android even though thecellcompoment is disabled (reference).Why?
Letting the user edit a UI element that is displayed as disabled can be confusing to the user.
How?
Looks like disabling the
TextInputcomponent using thedisabledprop is not enough to make it non-editable on Android. Hence, the value passed to theeditableprop will be set tofalseif the cell is disabled.Testing Instructions
In order to test this change, I created a test component to simplify the testing. The original issue was identified on Android, so it's recommended to test using the Android app.
Click here to display patch
Testing Instructions for Keyboard
N/A
Screenshots or screencast